Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance ERC6372 behavior test with detailed checks #5164

Merged

Conversation

techvoyagerX
Copy link
Contributor

Summary

This PR refactors the ERC6372.behavior.js test file to enhance clarity and improve the quality of the checks. The changes include:

  • Improved test descriptions for better readability.
  • Added more detailed assertions with custom error messages for better debugging.
  • Organized code to ensure consistency and maintainability.

Changes

  • Enhanced clock value comparison with custom error messages.
  • Improved the CLOCK_MODE parameter checks for mode and from values.

This refactor aims to make the ERC-6372 test suite more robust and easier to understand, facilitating future contributions and maintenance.

Impact

  • No changes to the core contract code, only test improvements.
  • Better test coverage with clear and concise descriptions.

Copy link

changeset-bot bot commented Aug 27, 2024

⚠️ No Changeset found

Latest commit: d83d660

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx merged commit f209815 into OpenZeppelin:master Sep 19, 2024
21 checks passed
Copy link

gitpoap-bot bot commented Sep 19, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 OpenZeppelin Contracts Contributor:

GitPOAP: 2024 OpenZeppelin Contracts Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants