Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance ERC6372 behavior test with detailed checks #5164

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions test/governance/utils/ERC6372.behavior.js
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
const { expect } = require('chai');

const time = require('../../helpers/time');

function shouldBehaveLikeERC6372(mode = 'blocknumber') {
describe('should implement ERC-6372', function () {
describe(`ERC-6372 behavior in ${mode} mode`, function () {
beforeEach(async function () {
this.mock = this.mock ?? this.token ?? this.votes;
});

it('clock is correct', async function () {
expect(await this.mock.clock()).to.equal(await time.clock[mode]());
it('should have a correct clock value', async function () {
const currentClock = await this.mock.clock();
const expectedClock = await time.clock[mode]();
expect(currentClock).to.equal(expectedClock, `Clock mismatch in ${mode} mode`);
});

it('CLOCK_MODE is correct', async function () {
const params = new URLSearchParams(await this.mock.CLOCK_MODE());
expect(params.get('mode')).to.equal(mode);
expect(params.get('from')).to.equal(mode == 'blocknumber' ? 'default' : null);
it('should have the correct CLOCK_MODE parameters', async function () {
const clockModeParams = new URLSearchParams(await this.mock.CLOCK_MODE());
const expectedFromValue = mode === 'blocknumber' ? 'default' : null;

expect(clockModeParams.get('mode')).to.equal(mode, `Expected mode to be ${mode}`);
expect(clockModeParams.get('from')).to.equal(expectedFromValue, `Expected 'from' to be ${expectedFromValue}`);
});
});
}
Expand Down