Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Boosted to v5.3.3 #158

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Bump Boosted to v5.3.3 #158

merged 5 commits into from
Mar 20, 2024

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Mar 12, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

Update Boosted version to v5.3.3 and associated changes.
Add .custom-select since it's the v4 version of .form-select.
Fix v4 accordion to behave the same as v5 ones.
Remove undefined class in v4.
Best effort fix for a bug where Boosted v4 doesn't load when having bad network to load jQuery (Could be done afterwards inside another PR if needed).

Motivation & Context

Be up to date with last version of Boosted.

Types of change

  • New feature (non-breaking change which adds functionality)

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test/angular-echarts
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart
  • test/examples/timeseries-chart

@louismaximepiton louismaximepiton added fix dependencies Pull requests that update a dependency file labels Mar 12, 2024
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit aa8c543
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/65faebf480133e0008a703b0
😎 Deploy Preview https://deploy-preview-158--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond
Copy link
Contributor

This PR might need to handle the newly merged section from #159

@julien-deramond julien-deramond merged commit 361a948 into main Mar 20, 2024
4 checks passed
@julien-deramond julien-deramond deleted the main-lmp-bump-boosted branch March 20, 2024 14:09
jacques-lebourgeois added a commit to louismaximepiton/ods-charts that referenced this pull request Apr 5, 2024
louismaximepiton pushed a commit to louismaximepiton/ods-charts that referenced this pull request Apr 25, 2024
louismaximepiton pushed a commit to louismaximepiton/ods-charts that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants