Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Token Update] - Update of typeBodyDefaultLarge #191

Closed
pylapp opened this issue Oct 11, 2024 · 4 comments
Closed

[Token Update] - Update of typeBodyDefaultLarge #191

pylapp opened this issue Oct 11, 2024 · 4 comments
Assignees
@pylapp
Labels
📀 token Related to tokens (raws, semantics or components) 🔍 triage A new issue that needs to be treated

Comments

@pylapp
Copy link
Member

pylapp commented Oct 11, 2024 •
edited
Loading

Description

The composite semantic token typeBodyDefaultLarge needs to be fixed ; it does not embed the good value

Motivation & Context

typeBodyStrongLarge and typeBodyDefaultLarge have the same values and should not ; typeBodyDefaultLarge should have a lighter weight
@pylapp pylapp added 📀 token Related to tokens (raws, semantics or components) 🔍 triage A new issue that needs to be treated labels Oct 11, 2024
@pylapp pylapp self-assigned this Oct 11, 2024
@pylapp pylapp changed the title [Token Update] - Update of typeBodyStrongLarge [Token Update] - Update of typeBodyDefaultLarge Oct 11, 2024
@pylapp pylapp moved this from Triage to In Progress in [OUDS] Project Oct 11, 2024
pylapp added a commit that referenced this issue Oct 11, 2024
@pylapp
fix: composite semantic token typeBodyDefaultLarge font weight (#191)
7bdc6b8 
Closes #191

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@pylapp pylapp mentioned this issue Oct 11, 2024
Merged
9 tasks
@pylapp
Copy link
Member Author

pylapp commented Oct 11, 2024

📣 New TestFlight ALPHA upload available 🚀

Please, get the new build from TestFlight app, or contact the project maintainers if you don't have access.

  • Display name: OUDS Showcase ALPHA (191)
  • Version: 0.4.0
  • Build number: 1728637472
  • Build tag: 7bdc6b8
  • Build type: ALPHA
  • Build details (GitHub): 191

cc @B3nz01d @pylapp @ludovic35 @Tayebsed93 @mccart77

This is an automated message sent with love and Fastlane from our CI/CD pipeline 🤘

ludovic35 pushed a commit that referenced this issue Oct 11, 2024
@pylapp
fix: font weight of composite semantic token typeBodyDefaultLarge (#…
54ab967 
…191) (#192)

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@pylapp pylapp closed this as completed Oct 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in [OUDS] Project Oct 11, 2024
@B3nz01d
Copy link
Collaborator

B3nz01d commented Oct 11, 2024 •
edited
Loading

I do see the body default been corrected in the alpha version of the app.
This is great

However, this issue is just an example as all font style do not differentiate strong and default. This token update needs to be corrected on all styles that have the difference:

  • body medium
  • body small
  • label XL
  • label Medium
  • label small

@pylapp
Copy link
Member Author

pylapp commented Oct 11, 2024

I let you check if the things must be updated and create dedicated issue(s) @B3nz01d

@pylapp pylapp mentioned this issue Oct 18, 2024
Merged
pylapp added a commit that referenced this issue Oct 18, 2024
@pylapp @ludovic35 @Tayebsed93
Release 0.4.0 (#206)
c8da6ec 
Release of version 0.4.0
See below the full CHANGELOG details.

Added

- [DemoApp] Update opacity screen with new design ([#200](#200))
- [DemoApp] Add color tokens screen in demo app ([#152](#152))
- [Library] Add semantic tokens `spacePaddingInlineTallest`, `spacePaddingBlockTallest`, `spaceColumnGapTaller`, `spaceColumnGapWithArrowShortest`, `spaceRowGapShortest` (Figjam final synchronization of October 16th)
- [Library] Add semantic color tokens ([#124](#124))
- [DemoApp] Fix some design issues and mutualize some UI elements ([#189](#189))
- [DemoApp] Add sizing tokens screen in demo app ([#150](#150))
- [DemoApp] Add spacing tokens screen in demo app ([#149](#149))
- [Library] Add color semantic tokens `colorContentTransparentDefault`, `colorBorderTransparentDefault` and `colorBackgroundTransparentDefault` (October 8th) ([#177](#177))
- [DemoApp] On opacity screen, add a border around the view showing the opacity ([#157](#157))

Changed

- [Library] Update of semantic typography tokens (Figjam final synchronization of October 16th)
- [Library] Update of semantic grid tokens `gridExtraCompactColumnCount`, `gridCompactColumnGap`, `gridRegularColumnGap` (Figjam final synchronization of October 16th)
- [Library] Update of semantic elevation token `elevationStickyNavigationScrolled` (Figjam final synchronization of October 16th)
- [Library] Update of semantic color tokens, semantic sizing tokens (Figjam final synchronization of October 16th)
- [Library/DemoApp] Updates SwiftLint rules, fix linter warnings ([#143](#143))
- [Tool] Update the templates for GitHub issues
- [Tool] Improve script for documentation generation ([#168](#168))
- [Library] Rename raw brand-specific color tokens in Orange theme (no use of "brand" word) ([#179](#179))
- [Library] `fontLetterSpacingMobile*` and `fontLetterSpacingTablet*` merged in `MultipleFontLetterSpacingTokens` objects
- [Library] `fontLineHeightMobile*` and `fontLineHeightTablet*` merged in `MultipleFontLineHeightTokens` objects
- [Library] `fontSizeMobile*` and `fontSizeTablet*` merged in `MultipleFontSizeTokens` objects 
- [Library] Update semantic and raw tokens for fonts ([#155](#155))
- [Library] Update semantic tokens for fonts (October 7th) ([#172](#172))
- [Library] Update raw tokens for fonts (October 7th) ([#170](#170))
- [Library] Any semantic token of sizing `TypeXXX` has been replaced by `TypeSizeXXX` (update of October 7th)
- [Library] Any semantic tokens of sizing `WithTypeXXX` has been replaced by `TypzeXXX` (update of October 7th)
- [Library] Update semantic tokens for sizing (October 7th) ([#173](#173))
- [Library] Any semantic tokens of spacing `isIcon` and `isArrow` are now `withIcon` and `withArrow` (update of October 7th)
- [Library] Update semantic tokens for spacing (October 4th) ([#174](#174))
- [Library] Update semantic tokens for spacing (October 4th) ([#156](#156))
- [Library] Update raw tokens for dimensions (October 7th) ([#169](#169))

Removed

- [Library] Raw typography token `fontSize100` (Figjam final synchronization of October 16th)
- [Library] Semantic token `spaceColumnGapWithArrowTaller` (Figjam final synchronization of October 16th)
- [Library] Remove all color alias semantic tokens and any optional color tokens type uses
- [Library] `SoshTheme` ([#180](#180))
- [Library] `fontSizeMobile*`, `fontSizeTablet*`, `fontLineHeightMobile*`, `fontLineHeightTablet*`, `fontLetterSpacingMobile*`, `fontLetterSpacingTablet*` removed (update of October 4th)
- [Library] `spaceRowGapWithIconTaller`, `spaceColumnGapWithIconTaller` removed (update of October 7th)

Fixed

- [Library] `typeBodyDefaultLarge` font weight ([#191](#191))

Co-authored-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Co-authored-by: Ludovic Pinel <ludovic.pinel@orange.com>
Co-authored-by: Tayeb Sedraia <tayeb.sedraia@orange.com>
@pylapp
Copy link
Member Author

pylapp commented Oct 18, 2024

ℹ️ Released with version v0.4.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylapp pylapp

Labels
📀 token Related to tokens (raws, semantics or components) 🔍 triage A new issue that needs to be treated
Projects
[OUDS] Project
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pylapp @B3nz01d