Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#191] Composite semantic token typeBodyDefaultLarge font weight update #192

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Oct 11, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#191

Description

typeBodyDefaultLarge needs to be fixed

Motivation & Context

typeBodyDefaultLargedoes not use the suitable tokens, its font weight is not the expected one

Types of change

  • Bug fix (non-breaking which fixes an issue)

Previews

#191

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • (NA) My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

Closes #191

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@pylapp pylapp self-assigned this Oct 11, 2024
@pylapp
Copy link
Member Author

pylapp commented Oct 11, 2024

@ludovic35 @Tayebsed93 Commit message should be like:

fix: font weight of composite semantic token `typeBodyDefaultLarge` (#191) (#192)

@ludovic35 ludovic35 merged commit 54ab967 into develop Oct 11, 2024
3 of 4 checks passed
@ludovic35 ludovic35 deleted the 191-update-typeBodyStrongLarge branch October 11, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants