Skip to content

Commit

Permalink
Prevent test windows to pull in node 20 (facebook#41200)
Browse files Browse the repository at this point in the history
Summary:
Since yesterday, Chocolatey is pulling in Node 20 rather than Node 18 for tests.
It ends up that mock-fs is not working with Node 20, so, for the time being, we are going to keep 18.

## Changelog:
[Internal] - Use node 18 instead of 20 for Test Windows

Pull Request resolved: facebook#41200

Test Plan: CircleCI is green

Reviewed By: hoxyq

Differential Revision: D50690846

Pulled By: cipolleschi

fbshipit-source-id: 505b8e8f90b46019d8e582cc8dad2e2d1edffd54
  • Loading branch information
cipolleschi authored and Othinn committed Oct 30, 2023
1 parent 51bfa96 commit 08fd246
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .circleci/configurations/jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ jobs:
- run:
name: Install Node JS
# Note: Version set separately for non-Windows builds, see above.
command: choco install nodejs-lts
command: choco install nodejs --version=18.18.0 --allow-downgrade

# Setup Dependencies
- run:
Expand Down

0 comments on commit 08fd246

Please sign in to comment.