[RN][CI] Prevent test windows to pull in node 20 #41200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: dffd9d2 |
cipolleschi
force-pushed
the
cipolleschi/fix_test_windows
branch
3 times, most recently
from
a15730c to
a6dff5e
Compare
cipolleschi
force-pushed
the
cipolleschi/fix_test_windows
branch
from
a6dff5e to
09a71b1
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 3d1d2f5. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
Summary: Since yesterday, Chocolatey is pulling in Node 20 rather than Node 18 for tests. It ends up that mock-fs is not working with Node 20, so, for the time being, we are going to keep 18. ## Changelog: [Internal] - Use node 18 instead of 20 for Test Windows Pull Request resolved: facebook#41200 Test Plan: CircleCI is green Reviewed By: hoxyq Differential Revision: D50690846 Pulled By: cipolleschi fbshipit-source-id: 505b8e8f90b46019d8e582cc8dad2e2d1edffd54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since yesterday, Chocolatey is pulling in Node 20 rather than Node 18 for tests.
It ends up that mock-fs is not working with Node 20, so, for the time being, we are going to keep 18.
Changelog:
[Internal] - Use node 18 instead of 20 for Test Windows
Test Plan:
CircleCI is green