RMET-2119 InAppBrowser Plugin - Check for element before obtaining it #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgerardojacinto
requested review from
nflsilva,
hectorjdgdev and
OS-ricardomoreirasilva
OS-martacarlos
approved these changes
Dec 20, 2022
nflsilva
approved these changes
Dec 21, 2022
alexgerardojacinto
added a commit
that referenced
this pull request
Jan 18, 2023
…#40) (#41) * fix: check if there's a next token before trying to obtain it References: https://outsystemsrd.atlassian.net/browse/RMET-2119 * chore: update changelog
alexgerardojacinto
added a commit
that referenced
this pull request
Aug 31, 2023
* RMET-2119 InAppBrowser Plugin - Check for element before obtaining it (#40) * fix: check if there's a next token before trying to obtain it References: https://outsystemsrd.atlassian.net/browse/RMET-2119 * chore: update changelog * RMET-2802 InAppBrowser Plugin - Multiple minor fixes from the community (#42) * Fix memory leak - initially reported in apache#290 Whenever closing an InAppBrowser instance, a webview was left in memory with about:blank page. This change fixes the issue by destroying and freeing the inAppWebView object. * Fix beforeLoad not being called in some requests - initially reported in apache#686 The waitForBeforeload flag was preventing beforeLoad from being called on every GET request. * Do not lose callbackContext when opening a SYSTEM url This fixes a condition where it was not possible to open a SYSTEM url while an InAppBrowser instance is displayed. The callbackContext of the InAppBrowser instance was lost when the SYSTEM url was opened. This fixes the issue by not setting the callbackContext on SYSTEM urls. * Fix crash when pausing/resuming application after closing InAppBrowser * Fix _loadAfterBeforeload callback not working due to this.rootName not being defined. * Reset beforeload variable if a new instance of InAppBrowser is opened without beforeload setting * chore: update changelog References: https://outsystemsrd.atlassian.net/browse/RMET-2802 * refactor: remove empty lines * refactor: use ternary operator and remove unnecessary ones Why: We can refactor the if-else block that assigns a value to beforeload to use a ternary operator. On the other hand, we can remove the unnecessary ternary operators used to assign a boolean value. They are redundant. References: https://outsystemsrd.atlassian.net/browse/RMET-2802 --------- Co-authored-by: Leonardo Monteiro Fernandes <leonardo.monteiro.fernandes@gmail.com> Co-authored-by: Nelson Lopes Silva <5671236+nflsilva@users.noreply.github.com> --------- Co-authored-by: Leonardo Monteiro Fernandes <leonardo.monteiro.fernandes@gmail.com> Co-authored-by: Nelson Lopes Silva <5671236+nflsilva@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you want to test it, there is an app in a ODC environment available for testing: https://eng-dev-us-10.outsystems.dev/apps/application?id=6f044e5a-2130-41b9-b1ba-f965207c9720&stageid=03cc943d-c007-4e6f-9a95-01db3e1f2d2d&tab=mobiledistribution
Context
References: https://outsystemsrd.atlassian.net/browse/RMET-2119
Type of changes
Platforms affected
Tests
Tested MABS 8 and 9 builds. Tested plugin in Android 12 device. Tested on both O11 and ODC.
Screenshots (if appropriate)
Checklist
RNMT-XXXX <title>