beforeload event fires only on odd links

[koekaverna]

Bug Report

Problem

the 'beforeload' odd fires only on even links, on even links it doesn’t work

What is expected to happen?

It should fire always

What does actually happen?

It fire only odd (half times)

Information

Repository to reproduce
https://github.com/koekaverna/cordova-inapp-testing

Command or Code

Tested with chome DevTools: chrome://inspect/#devices console output
and android emulator

Environment, Platform, Device

Pixel_2_API_R:5584

Version information

Cordova: 9.0.0 (cordova-lib@9.0.1)

Checklist

• I searched for existing GitHub issues
• I updated all Cordova tooling to most recent version
• I included all the necessary information above

[dpa99c]

I am able to repro this: the beforeload event is only being fired intermittently because the native shouldOverrideUrlLoading method is being called intermittently.

I've found a solution which seems to work in this SO answer - adding this seems to resolve the issue and beforeload is fired on every request as would be expected on Android:

inAppWebView.getSettings().setMixedContentMode(WebSettings.MIXED_CONTENT_ALWAYS_ALLOW);

While MIXED_CONTENT_ALWAYS_ALLOW is not recommended, setting MIXED_CONTENT_COMPATIBILITY_MODE or MIXED_CONTENT_NEVER_ALLOW seems to cause the intermittent failure to invoke shouldOverrideUrlLoading, so I would propose setting MIXED_CONTENT_ALWAYS_ALLOW to resolve this issue.

[PDLMobileApps]

I am able to repro this: the beforeload event is only being fired intermittently because the native shouldOverrideUrlLoading method is being called intermittently.

I've found a solution which seems to work in this SO answer - adding this seems to resolve the issue and beforeload is fired on every request as would be expected on Android:

inAppWebView.getSettings().setMixedContentMode(WebSettings.MIXED_CONTENT_ALWAYS_ALLOW);

While MIXED_CONTENT_ALWAYS_ALLOW is not recommended, setting MIXED_CONTENT_COMPATIBILITY_MODE or MIXED_CONTENT_NEVER_ALLOW seems to cause the intermittent failure to invoke shouldOverrideUrlLoading, so I would propose setting MIXED_CONTENT_ALWAYS_ALLOW to resolve this issue.

We looked into that and it did not solve the issue. However, PR#755 does solve it. The code that is modified in that PR seems to be quite old/obsolete and causes the issue reported in this bug. Could any reviewer consider reviewing it? Thanks!