Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Code Style and Pre-PR Formatting Checks #26

Closed
mblomdahl opened this issue Mar 6, 2024 · 0 comments · Fixed by #27
Closed

Add Code Style and Pre-PR Formatting Checks #26

mblomdahl opened this issue Mar 6, 2024 · 0 comments · Fixed by #27
Assignees
@mblomdahl
Labels
documentation Improvements or additions to documentation

Comments

@mblomdahl
Copy link
Contributor

From PR #19 review, we lack some basic editor setup hints. Review the React Editor Setup recommendations and implement so it is easy to use with GitHub Codespaces.

(Originally posted by @mblomdahl in #19 (comment))
@mblomdahl mblomdahl self-assigned this Mar 6, 2024
@mblomdahl mblomdahl added the documentation Improvements or additions to documentation label Mar 6, 2024
mblomdahl added a commit to mblomdahl/web-client that referenced this issue Mar 6, 2024
@mblomdahl
Add ESLint and Prettier Configs OwnTube-tv#26
cc6f0ff 
1. ESLint added with the recommended settings, https://react.dev/learn/editor-setup#your-editor
2. Some basic VS Code settings, non-platform specific
3. Apply recommended changes from ESLint to `App.tsx`
mblomdahl added a commit to mblomdahl/web-client that referenced this issue Mar 6, 2024
@mblomdahl
Add ESLint and Prettier Configs OwnTube-tv#26
0f6d0d1 
1. ESLint added with the recommended settings, https://react.dev/learn/editor-setup#your-editor
2. Some basic VS Code settings, non-platform specific
3. Apply recommended changes from ESLint to `App.tsx`

FIXME(@mblomdahl): Prettier-formatteringen fungerar ej! Fixa innan PR!
mblomdahl added a commit to mblomdahl/web-client that referenced this issue Mar 6, 2024
@mblomdahl
Add ESLint and Prettier Configs OwnTube-tv#26
6cc9049 
1. ESLint added with the recommended settings, https://react.dev/learn/editor-setup#your-editor
2. Some basic VS Code settings, non-platform specific
3. Apply recommended changes from ESLint to `App.tsx`
mblomdahl added a commit to mblomdahl/web-client that referenced this issue Mar 6, 2024
@mblomdahl
Add ESLint and Prettier Configs OwnTube-tv#26
a4cfffe 
1. ESLint added with the recommended settings, https://react.dev/learn/editor-setup#your-editor
2. Some basic VS Code settings, non-platform specific
3. Apply recommended changes from ESLint to `App.tsx`
4. README update on contributing code changes, PR checklist
mblomdahl added a commit to mblomdahl/web-client that referenced this issue Mar 6, 2024
@mblomdahl
Add ESLint and Prettier Configs OwnTube-tv#26
04c09f3 
1. ESLint added with the recommended settings, https://react.dev/learn/editor-setup#your-editor
2. Some basic VS Code settings, non-platform specific
3. Apply recommended changes from ESLint to `App.tsx`
4. README update on contributing code changes, PR checklist
@mblomdahl mblomdahl mentioned this issue Mar 6, 2024
Merged
mblomdahl added a commit that referenced this issue Mar 17, 2024
@mblomdahl
Add ESLint and Prettier Configs #26 (#27)
d034fca 
1. ESLint added with the recommended settings, https://react.dev/learn/editor-setup#your-editor
2. Some basic VS Code settings, non-platform specific
3. Apply recommended changes from ESLint to `App.tsx`
4. README update on contributing code changes, PR checklist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mblomdahl mblomdahl

Labels
documentation Improvements or additions to documentation
Projects
Embeddable React Native Client
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ESLint and Prettier Configs #26 mblomdahl/web-client
1 participant
@mblomdahl