Create a Service for providing video/category data #10 #19

OGTor · 2024-02-19T14:17:18Z

New Feature Submissions:

This will add Services for providing video/category data

Data can be is reusable for different components.

To Test

Open project and use
npm run web
open the console in your desired web-browser
you will se different console logs with Category Labels, Videos, etc

mblomdahl

Please update the PR so it is to-the-point and crisp to review with respect to the scope in #10, then press the "re-request review" to invite another review when you feel it is sufficiently succinct. You should also enable the GitHub Actions workflow to demonstrate that it builds and that a reviewer can experience the new functions deployed on GitHub Pages (see PR #20 and the previous ones for good examples).

OwnTube.tv/yarn.lock

package.json

testData.json

OwnTube.tv/package.json

.vscode/settings.json

OGTor · 2024-02-22T07:59:13Z

Updated upon reviews

Link to commited changes

https://ogtor.github.io/web-client/

ar9708

FYI, checkboxes to tick @OGTor & @tryklick :

TODOs:

Linear history
Signed commints

OGTor

Final fix for testData.json.
This update should fix the problem with Actions not loading testData.json

OGTor · 2024-03-06T11:46:05Z

Final fix for testData.json. This update should fix the problem with Actions not loading testData.json

https://ogtor.github.io/web-client/

@OGTor

This PR adds test coverage for the behavior described in task OwnTube-tv#10 using Jest, which seems to be the test framework of choice for React Native (see [Testing docs here](https://reactnative.dev/docs/testing-overview#unit-tests)). @OGTor please merge this in and update your VideoService to pass all tests without test suite modifications!

mblomdahl

My feedback was a bit too broad to fit into the "comment on lines" format here, so I have summarized my concerns in 2 PRs from my own fork instead to provide more clear assistance. See OGTor/web-client#1 for the addition of test coverage related to #10, then see mblomdahl#1 for a small example and (primarily) a list of refactorings that are needed to make this mergeable.

mblomdahl

It's looking good when I open https://ogtor.github.io/web-client/, good job! Please rebase your branch on latest main to resolve conflicts and clean up the commits (see hint in #24 (comment)). Check the boxes in on @ar9708's review #19 (review) when done. Press re-request review when you think all the file changes in this PR look correct. ⭐

@OGTor

This PR adds test coverage for the behavior described in task OwnTube-tv#10 using Jest, which seems to be the test framework of choice for React Native (see [Testing docs here](https://reactnative.dev/docs/testing-overview#unit-tests)). @OGTor please merge this in and update your VideoService to pass all tests without test suite modifications!

@OGTor

This PR adds test coverage for the behavior described in task OwnTube-tv#10 using Jest, which seems to be the test framework of choice for React Native (see [Testing docs here](https://reactnative.dev/docs/testing-overview#unit-tests)). @OGTor please merge this in and update your VideoService to pass all tests without test suite modifications!

@OGTor

This PR adds test coverage for the behavior described in task OwnTube-tv#10 using Jest, which seems to be the test framework of choice for React Native (see [Testing docs here](https://reactnative.dev/docs/testing-overview#unit-tests)). @OGTor please merge this in and update your VideoService to pass all tests without test suite modifications!

@OGTor

This PR adds test coverage for the behavior described in task OwnTube-tv#10 using Jest, which seems to be the test framework of choice for React Native (see [Testing docs here](https://reactnative.dev/docs/testing-overview#unit-tests)). @OGTor please merge this in and update your VideoService to pass all tests without test suite modifications!

@OGTor

This PR adds test coverage for the behavior described in task OwnTube-tv#10 using Jest, which seems to be the test framework of choice for React Native (see [Testing docs here](https://reactnative.dev/docs/testing-overview#unit-tests)). @OGTor please merge this in and update your VideoService to pass all tests without test suite modifications! (Demo-rebase med @OGTor och @mblomdahl!)

OGTor

in videoServices.test.tsx it seems as this code part (line 47 - 50)

    type Category = {
      id: number;
      label: string;
    };

is not used in the testing

mblomdahl

It's improving! Good job, here's a few comments on the actual code implementation.

Please also address the comment here, #19 (review), about signing your commits.

OwnTube.tv/Services/VideoDataService.tsx

OwnTube.tv/Services/videoServices.tsx

@OGTor

(Demo-rebase with @OGTor & @mblomdahl!)

@OGTor

Changes: - Removed root-level package.json and package-lock.json - Removed package.json dependency on `peertube/embed-api` - Moved testData.json from root level to `OwnTube.tv/` Node project directory - Load testData.json via CommonJS import instead of HTTP request to web server From commits 4/3 to 6/3: - github actions testData fix v11 - github actions testData fix v10 - revert - test - github actions testData fix v9 - github actions testData fix v8 - github actions testData fix v7 - github actions testData fix v6 - github actions testData fix v5 - github actions testData fix v4 - github actions testData fix v3 - github actions testData fix - github actions testData fix - Changes information in testData.json - Fixes: Changed to using testData instead of test API - Create a Service for providing video/category data #10 (Rebase-demo med @OGTor och @mblomdahl!)

@OGTor

This PR adds test coverage for the behavior described in task #10 using Jest, which seems to be the test framework of choice for React Native (see [Testing docs here](https://reactnative.dev/docs/testing-overview#unit-tests)). @OGTor please merge this in and update your VideoService to pass all tests without test suite modifications! (Demo-rebase med @OGTor och @mblomdahl!)

Changes: - Updated `videoService.tsx` to pass all tests - Updated `VideoDataService.tsx` to render app landing page with videos **in** categories From squashed updates from 15/3 to 22/3: - final commit v2 - Revert "Final commit", This reverts commit 5b94307. - Final commit - test fix v3 - test fix v2 - fix for testing - Create a Service for providing video/category data #10 - final changes - changed category

ar9708

Good job! Starting to look neat and crispy. 🌟 Please see my comments below.

OwnTube.tv/components/videosOverview.tsx

OwnTube.tv/types.ts

ar9708

@OGTor Your GitHub Actions pipeline is failing, please address!

ar9708

Great, looking good! 🙃

This reverts commit 1ed0943.

OGTor linked an issue Feb 20, 2024 that may be closed by this pull request

Create a Service for providing video/category data #10

Closed

3 tasks

OGTor requested review from mblomdahl, tryklick and ar9708 February 20, 2024 07:34

mblomdahl requested changes Feb 20, 2024

View reviewed changes

OwnTube.tv/yarn.lock Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

testData.json Outdated Show resolved Hide resolved

OwnTube.tv/package.json Outdated Show resolved Hide resolved

.vscode/settings.json Outdated Show resolved Hide resolved

OGTor requested a review from mblomdahl February 26, 2024 08:35

tryklick approved these changes Feb 26, 2024

View reviewed changes

ar9708 requested changes Feb 28, 2024

View reviewed changes

mblomdahl mentioned this pull request Mar 5, 2024

Implement Initial Landing Page Components for Project Description #11 #24

Closed

OGTor commented Mar 6, 2024

View reviewed changes

mblomdahl mentioned this pull request Mar 6, 2024

Add Code Style and Pre-PR Formatting Checks #26

Closed

mblomdahl requested changes Mar 7, 2024

View reviewed changes

tryklick closed this Mar 12, 2024

tryklick reopened this Mar 12, 2024

mblomdahl mentioned this pull request Mar 14, 2024

Video services changes #30

Closed

9 tasks

OGTor requested review from mblomdahl and tryklick March 21, 2024 07:34

mblomdahl requested changes Mar 21, 2024

View reviewed changes

OGTor commented Apr 1, 2024

View reviewed changes

OGTor requested review from mblomdahl and ar9708 April 1, 2024 21:00

mblomdahl requested changes Apr 2, 2024

View reviewed changes

OGTor self-assigned this Apr 11, 2024

OGTor added 7 commits April 11, 2024 08:19

Create a Service for providing video/category data #10

caa5dcc

(Demo-rebase with @OGTor & @mblomdahl!)

Remove type Category

6ea63b2

Prettier & remove extra testData.json

7dd8f1c

update after review 2

1aa613e

tryklick approved these changes Apr 16, 2024

View reviewed changes

changes after eslint errors

7680045

OGTor requested review from tryklick and mblomdahl April 17, 2024 06:35

ar9708 reviewed Apr 18, 2024

View reviewed changes

OwnTube.tv/components/videosOverview.tsx Outdated Show resolved Hide resolved

OwnTube.tv/types.ts Outdated Show resolved Hide resolved

ar9708 reviewed Apr 18, 2024

View reviewed changes

OwnTube.tv/types.ts Outdated Show resolved Hide resolved

Moved VideoServiceState, Fixed thumbnail Render

f9ec618

OGTor requested a review from ar9708 April 19, 2024 06:59

ar9708 requested changes Apr 19, 2024

View reviewed changes

Removed inline styling for eslint error

d3fb8b6

OGTor requested a review from ar9708 April 19, 2024 09:35

ar9708 approved these changes Apr 19, 2024

View reviewed changes

mblomdahl approved these changes Apr 19, 2024

View reviewed changes

mblomdahl mentioned this pull request Apr 19, 2024

Create initial components for rendering the landing page #11 #24 #32

Closed

9 tasks

tryklick merged commit 1ed0943 into OwnTube-tv:main Apr 21, 2024

tryklick added a commit that referenced this pull request Apr 21, 2024

Revert " Create a Service for providing video/category data #10 (#19)"

ec98979

This reverts commit 1ed0943.

ar9708 mentioned this pull request Apr 25, 2024

Extend the VideoService to support using live API data #37

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a Service for providing video/category data #10 #19

Create a Service for providing video/category data #10 #19

OGTor commented Feb 19, 2024

mblomdahl left a comment

OGTor commented Feb 22, 2024

ar9708 left a comment •

edited by tryklick

Loading

OGTor left a comment

OGTor commented Mar 6, 2024

mblomdahl left a comment

mblomdahl left a comment

OGTor left a comment

mblomdahl left a comment

ar9708 left a comment

ar9708 left a comment

ar9708 left a comment

Create a Service for providing video/category data #10 #19

Create a Service for providing video/category data #10 #19

Conversation

OGTor commented Feb 19, 2024

New Feature Submissions:

To Test

mblomdahl left a comment

Choose a reason for hiding this comment

OGTor commented Feb 22, 2024

Updated upon reviews

Link to commited changes

ar9708 left a comment • edited by tryklick Loading

Choose a reason for hiding this comment

OGTor left a comment

Choose a reason for hiding this comment

OGTor commented Mar 6, 2024

mblomdahl left a comment

Choose a reason for hiding this comment

mblomdahl left a comment

Choose a reason for hiding this comment

OGTor left a comment

Choose a reason for hiding this comment

mblomdahl left a comment

Choose a reason for hiding this comment

ar9708 left a comment

Choose a reason for hiding this comment

ar9708 left a comment

Choose a reason for hiding this comment

ar9708 left a comment

Choose a reason for hiding this comment

ar9708 left a comment •

edited by tryklick

Loading