Improve Calcium integration #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobianas
force-pushed
the
improve-calcium
branch
2 times, most recently
from
3aaf2b5 to
8783bb7
Compare
The addCallback methods do not need to be implemented since they are default. Also change the future method to return completed future since it's not chained. JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Just use .namespace() to return namespace, and if namespace is null, just use name. JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
No need to import these classes when ImmutableNodes can beused for same purpose. JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
This service is no longer required as a part of this rework: opendaylight/controller@9917911 JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Use these changes to modernize RPC implementation registration: opendaylight/lispflowmapping@27c0004 JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
There is no need to bind it again, since it is already bound from DOMSchemaService. JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Reformat the code a little to improve its readability. JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4444104#r139516959 - resolved in: https://github.com/PANTHEONtech/lighty/blob/main/lighty-core/lighty-clustering/src/main/java/io/lighty/core/cluster/kubernetes/KubernetesClusteringHandlerImpl.java#L107
787885f#r139516823 - resolved in: https://github.com/PANTHEONtech/lighty/blob/main/lighty-modules/lighty-bgp/src/main/java/io/lighty/modules/bgp/deployer/BgpModule.java#L152
2b4be02#r139516722 - resolved in: c5ae862
#1813 (comment) - no longer present: https://github.com/PANTHEONtech/lighty/blob/main/lighty-core/lighty-clustering/src/main/java/io/lighty/core/cluster/kubernetes/KubernetesClusteringHandlerImpl.java#L108
#1813 (comment) - resolved in: 7bbeb68
#1813 (comment) - unable to fix(see comment)
#1813 (comment) - resolved in: 0574650
#1813 (comment) - resolved in: 91c849d
#1813 (comment) - resolved in: 8b87c41
#1813 (comment) - resolved in: f505c59