feat(dataverse-integration): add base classes and templates #190
Conversation
jmurugan-fzj
commented
Jan 30, 2024
jmurugan-fzj
commented
- Added the base UI files along with the extensions for the dataverse integration feature. Just added the basic UI files and the base classes with minimal/dummy functionality
- Added the backend thread-task extension for concurrent uploads in the background with an upload manager
- Added base database API for creating/retrieving documents/design documents/views etc. along with an extension for dataverse operations and database models
… integration feature - Added the backend thread-task extension for concurrent uploads in the background with an upload manager - Added base database API for creating/retrieving documents/design documents/views etc. along with an extension for dataverse operations and database models
- Code cleanup and refactoring
- Code cleanup and refactoring
- Code cleanup and refactoring
- Code cleanup and refactoring
|
@SteffenBrinckmann Could you please review this one, just all the basic classes needed are added even though the functionality is not as fully required, once the base classes are in, I will implement each functionality as separate PRs.. You could test this quickly in your system too, but the upload functionality is still showing dummy progress.. |
There was a problem hiding this comment.
Why do you need all those libraries?
There was a problem hiding this comment.
@SteffenBrinckmann Without which this leads to the same error (github action "Verify Linux install / build ") what you have notice as part of your PR #195
There was a problem hiding this comment.
@SteffenBrinckmann Sorry, I had removed all the un-necessary libs and included only Mesa 3D Graphics library which is needed by both the actions..
|
@SteffenBrinckmann Could you review and help me finalize this PR soon? |
|
@jmurugan-fzj could you look at the other two comments, that I had asked. A short answer suffices. |
@SteffenBrinckmann I see only one comment regarding the libs, are you sure you posted it or still in review? |
There was a problem hiding this comment.
Why is this not part of the GUI, it requires Qt.... which is GUI
There was a problem hiding this comment.
This only signals the UI with the data updates, does not directly do anything with UI or manage the UI items, only for signals, it's requires QT
There was a problem hiding this comment.
line 107: should it not be doc['-type'][0] == 'x0'?
There was a problem hiding this comment.
@SteffenBrinckmann Good point, I changed the logic to check if the type includes 'x0', but why do we have the type defined as an array, does that mean that there is a possibility in PASTA to have any document with multiple entries for the type field? eg. doc['-type'] = ['x0', 'some_other_type', ..]?
jmurugan-fzj
deleted the
feature/10-dataverse-base-classes-templates-check-in
branch
