Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ontology): added tests for the ontology editor #23

Merged
merged 82 commits into from
Sep 12, 2023
Merged

feat(ontology): added tests for the ontology editor #23

merged 82 commits into from
Sep 12, 2023

Conversation

jmurugan-fzj
Copy link
Contributor

  • Added the unit tests & components tests for the ontology editor
  • Modifications done for the myPy and pylint
  • Other adaptations as per the tests and also other modifications

@jmurugan-fzj
Added a test function to test the launch of GUI window and other mino…
e4382a1 
…r changes too
@jmurugan-fzj
-Code Cleanup
b3b7074
@jmurugan-fzj
-Code Cleanup
759f1f5
@jmurugan-fzj
-Corrected the package references
8aa0b8d
@jmurugan-fzj
- Added coverage and a sample report to the project
5d50494
@jmurugan-fzj
- Code Cleanup
81b1b0d
@jmurugan-fzj
- Code Cleanup
8f36c00
@jmurugan-fzj
- Code Reformatting
2ab5b4a
@jmurugan-fzj
- Corrected the pytest path (Only included app-tests and excluded the…
bff7d7e 
… others to avoid error, can be enabled later)
@jmurugan-fzj
- Added copyright information
439c57e
@jmurugan-fzj
- Added basic window for the Ontology editor
2028892 
- Disabled the failing tests and also added the new coverage data
@jmurugan-fzj
- Added logic to load the data from database
0555bbc
@jmurugan-fzj
- Added data model to populate the table view in the ontology editor
42842ae
@jmurugan-fzj
- Corrected the issues with the properties table data load and displa…
8130ca6 
…y of the item, selection of combobox, display various properties appropriately in the table view

- Added tooltips to the buttons, corrected the editing of the table items
@jmurugan-fzj
- Added the buttons for the deleting, reordering the properties table
5342c81 
- Minor fixes too
@jmurugan-fzj
- Added logic to insert a new property row to the table view
3454a28
@jmurugan-fzj
- Added a separate table for the attachments
c554ef6 
- Corrected the required radioButton functionality of property table view
@jmurugan-fzj
- Removed the unwanted scrollArea and added a few modifications in th…
6ff7627 
…e UI
@jmurugan-fzj
- Added logic to enter new type (structural and normal ones), delete …
570418f 
…the data type etc..

- Added logic to categorize the properties, delete categories too
- Minor fixes and other changes
@jmurugan-fzj
- Added message for save callback
bef2376
@jmurugan-fzj
- Quick code refactorings
b85405c
@jmurugan-fzj
- Added link line edit for the type level also with logic to modify t…
1e95e2f 
…he link and save the same too

- Adapted the UI layout and other minor tweaks
@jmurugan-fzj
- Added ontology_attachments_tableview_data_model.py to display the a…
ca77bd7 
…ttachments rightly in the table view
@jmurugan-fzj
- Refactored the modules and added necessary comments and documentation
b08a7a8 
- Cleaned up the un-necessary code and re-structured all the elements too
@jmurugan-fzj
- Modified the OntologyConfigurationForm to take ontology document di…
98df1cf 
…rectly as a parameter instead of db instance

- Added exceptions and some more refactorings
@jmurugan-fzj
- Modified the OntologyConfigurationForm to take ontology document di…
b6dc2cb 
…rectly as a parameter instead of db instance

- Added exceptions and some more refactorings
@jmurugan-fzj
- Corrected the test_form_launch for the modified UI elements
e46de1e
@jmurugan-fzj
- Restructured the tests folder and files
f313a0b
@jmurugan-fzj
- Corrected the column name for the attachment table
da91574
@jmurugan-fzj
- Corrected the default ontology in the fixedStringsJson.py
8d1931b 
- Some other changes too
@jmurugan-fzj jmurugan-fzj added the enhancement New feature or request label Sep 7, 2023
jmurugan-fzj and others added 17 commits September 7, 2023 17:21
@jmurugan-fzj
- Reverted fixedStringsJson.py to the old version
2ec6195
@jmurugan-fzj
- Enabled test_99_3Projects.py also for improved coverage
19992fb
@jmurugan-fzj
- Enabled re-enabled failing tests test_01_demoIndentation.py & test_…
320cd0e 
…02_demoIndentation_ExportImport.py
@jmurugan-fzj
- Committed the missing test data document
b376e45
@jmurugan-fzj
-Removed test user credentials from the ontology_configuration_extend…
d47f534 
…ed.py script
@SteffenBrinckmann
- Moved ontology-configuration into GUI and all the imports are now r…
9c78ec5 
…elative

- Adopted gui.py (main section) to supply the current ontology and that ontology is present in line ~70 of ontology_configuration_extended and it gets translated into v3
- When I click on load it is shown

Hints for fast testing:
- start pasta usual way:
- restart with F9
- open ontology config F8 (for now and for testing)
@jmurugan-fzj
-Modified the tests and corrected linting errors as per the changes f…
4920b93 
…rom Steffen
@jmurugan-fzj
- Modifications done as per the pyLint and myPy errors
61313e0
@jmurugan-fzj
- Modifications done for the tests as per the pyLint and myPy errors
fc55353
@jmurugan-fzj
- Code cleanup
af80ab2
@jmurugan-fzj
- Added type-ignored for pyside ItemDataRole and int compatibility my…
fecc83f 
…py errors
@jmurugan-fzj
- Added type-ignore for pyside types, return type compatibility error…
d8e088d 
…s etc.
@jmurugan-fzj
Merge remote-tracking branch 'origin/main' into feature/ontology_edit…
1cb6537 
…or_tests
@jmurugan-fzj
- Formatted the test file test_ontology_configuration_extended.py
e3f4638
@jmurugan-fzj
Merge remote-tracking branch 'origin/main' into feature/ontology_edit…
e7cef29 
…or_tests
@jmurugan-fzj
- Added follow-import:skip for the ontology configuration folder, sin…
eea42f7 
…ce this was still including the excluded files for myPy check
@jmurugan-fzj
Merge remote-tracking branch 'origin/main' into feature/ontology_edit…
375717b 
…or_tests
@SteffenBrinckmann
Copy link
Contributor

  • htmlcov is autogenerated and should not be on git. Please add it to .gitignore
  • version number in -ontology- in the database should be 3 (not 2)
  • Suggestion: can you please flatten the hierarchy structure into ontology_configuration

@jmurugan-fzj
Copy link
Contributor Author

  • htmlcov is autogenerated and should not be on git. Please add it to .gitignore
  • version number in -ontology- in the database should be 3 (not 2)
  • Suggestion: can you please flatten the hierarchy structure into ontology_configuration
  • Removed the coverage files
  • Version number updated to 3.0
  • File hierarchy been flattened to single level

@jmurugan-fzj
- Corrected the path of the excluded files in setup.cfg
5e82cf9 
- Corrected the order of import, inorder to resolve pylint errors
@jmurugan-fzj
- Corrected the path of the excluded files in setup.cfg
78294a4 
- Corrected the order of import, inorder to resolve pylint errors
@jmurugan-fzj
- Updated version number in test data
9ffe2c9
@jmurugan-fzj jmurugan-fzj merged commit f58816e into main Sep 12, 2023
@jmurugan-fzj jmurugan-fzj deleted the feature/ontology_editor_tests branch September 12, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteffenBrinckmann SteffenBrinckmann SteffenBrinckmann approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmurugan-fzj @SteffenBrinckmann