Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescale all text documents in details, when the splitter changes size #244

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

SteffenBrinckmann
Copy link
Contributor

Fix #98

  • Rescale all text documents in details, when the splitter changes size
  • prevent crashes if dict2ul gets bad dictionary

- prevent crashes if dict2ul gets bad dictionary
value = json.loads(value.replace("'",'"'))
try:
value = json.loads(value.replace("'",'"'))
except:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to error log the exception?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the exception is triggered, the display in the GUI is not as beautiful as if the exception is not triggered. No big issue right now

@SteffenBrinckmann SteffenBrinckmann merged commit 4611c08 into main Apr 2, 2024
10 checks passed
@SteffenBrinckmann SteffenBrinckmann deleted the sb_98_rescaleTextDocementsInDetails branch April 2, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display of comments in views
2 participants