Fix #241: WIndows installation #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test if .NET 3.5 is installed - add this requirement to the documentation
SteffenBrinckmann
added this to the Version 2.5.1: important bug-fixes and other improvements milestone
jmurugan-fzj
reviewed
Apr 4, 2024
| ''' | ||
| import subprocess | ||
| command = ['reg','query','HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\NET Framework Setup\\NDP','/s'] | ||
| result = subprocess.run(command, stdout=subprocess.PIPE, check=True) |
There was a problem hiding this comment.
If it's always looking for just "Version 3.5" why cannot we simply check
if "Version 3.5" in result ??
There was a problem hiding this comment.
So we allow only this specific version of .NET, is this intended?
b'Version REG_SZ 3.5'
There was a problem hiding this comment.
@SteffenBrinckmann Ahh Okay, please see the failing GitHub actions!
|
@jmurugan-fzj Thank you for pointing out this: I updated that code and tested it on my windows partition |
jmurugan-fzj
approved these changes
Apr 4, 2024
| ''' | ||
| import subprocess | ||
| command = ['reg','query','HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\NET Framework Setup\\NDP','/s'] | ||
| result = subprocess.run(command, stdout=subprocess.PIPE, check=True) |
There was a problem hiding this comment.
So we allow only this specific version of .NET, is this intended?
b'Version REG_SZ 3.5'
|
@jmurugan-fzj The user can have multiple .net versions installed: my system has >10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 241