Drag drop #262
Merged
Drag drop #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmurugan-fzj
approved these changes
Apr 11, 2024
pasta_eln/GUI/project.py
Outdated
| @@ -314,6 +314,7 @@ def modelChanged(self, item:QStandardItem) -> None: | |||
| Args: | |||
| item (QStandardItem): item changed, new location | |||
| """ | |||
| print('start project model changed') | |||
There was a problem hiding this comment.
Please use log.info instead of print, if not needed please remove the comment
There was a problem hiding this comment.
@jmurugan-fzj Thanks, this was an old debugging message, I forgot to remove. Removed it now
pasta_eln/GUI/projectTreeView.py
Outdated
| @@ -171,6 +172,61 @@ def tree2Clicked(self) -> None: | |||
| return | |||
|
|
|||
|
|
|||
| def dragEnterEvent(self, event:QMouseEvent) -> None: | |||
| """ | |||
| Overwrite default: what happens if you drag an item | |||
There was a problem hiding this comment.
Did you mean "override"? Is this a base class function which is been overridden here in this clasS?
pasta_eln/GUI/projectTreeView.py
Outdated
|
|
||
| def dropEvent(self, event:QMouseEvent) -> None: | ||
| """ | ||
| Overwrite default: what happens at end of drag&drop |
pasta_eln/GUI/projectTreeView.py
Outdated
| elif 'application/x-qstandarditemmodeldatalist' in event.mimeData().formats(): | ||
| super().dropEvent(event) | ||
| else: | ||
| print('Drop unknown data', event.mimeData().formats()) |
There was a problem hiding this comment.
use log.warning! or log.error if you need to see the message in console too..!!
There was a problem hiding this comment.
You are correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement drag and drop of external files, which was requested in #12