Sb python3.12

[SteffenBrinckmann]

No description provided.

[SteffenBrinckmann]

@jmurugan-fzj ready for review: mypy will fail until pyside6.7.... is released. There is a bug in that that causes mypy to fail. N

[SteffenBrinckmann]

@jmurugan-fzj Can you understand these pytest issues, why is Save not part of the buttonbox anymore?

• the mypy test: I would ignore for now as it is a github-action / upstream issue (https://bugreports.qt.io/browse/PYSIDE-2696?attachmentViewMode=list and https://bugreports.qt.io/browse/PYSIDE-2665). On my python 3.12 with that pyside version there is no issue.
• the comment in gui.py: I would leave in because it shows how the code should be, once the upstream bug is fixed. I also left the links so we easily can see if they are fixed. The main got a P2:Important priority. The current version is a work-around which works but is not ideal.

[jmurugan-fzj]

@jmurugan-fzj Can you understand these pytest issues, why is Save not part of the buttonbox anymore?

• the mypy test: I would ignore for now as it is a github-action / upstream issue (https://bugreports.qt.io/browse/PYSIDE-2696?attachmentViewMode=list and https://bugreports.qt.io/browse/PYSIDE-2665). On my python 3.12 with that pyside version there is no issue.
• the comment in gui.py: I would leave in because it shows how the code should be, once the upstream bug is fixed. I also left the links so we easily can see if they are fixed. The main got a P2:Important priority. The current version is a work-around which works but is not ideal.

@SteffenBrinckmann Where do you see all these problems related to "Save" button? I see only a single error in the myPy action which is something related to indentation within base library file!

[SteffenBrinckmann]

@jmurugan-fzj Sorry for being unclear: can you understand why PyTest&Coverage fails? There are some strange messages.

[SteffenBrinckmann]

Myself:

• There are also many warnings in pytest about fontawesome: repair those in this PR as well
  • The FontAwesome 4.7 ('fa' prefix) icon set will be removed in a future release in favor of FontAwesome 6. We recommend you to move to FontAwesome 5 ('fa5*' prefix) to prevent any issues in the future
  • make all github actions use the same python version
    Did those changes

[jmurugan-fzj]

@jmurugan-fzj Sorry for being unclear: can you understand why PyTest&Coverage fails? There are some strange messages.

@SteffenBrinckmann Corrected and committed the errors with 'PySide6.QtWidgets.QDialogButtonBox' already, there are a few other errors which needs further investigation! Need some more time..If you are working on this PR already, please move it out of draft state anyhow to see the updates from actions for the commits..

[SteffenBrinckmann]

@jmurugan-fzj The new version of pyside is out and it has the corrected grammar. Since we update from pyside 6.2... to 6.7... the types have become much more defined and consistent. As a result, I had to correct 200 mypy issues. The remaining mypy issues are from your code. How do we continue?

[jmurugan-fzj]

@jmurugan-fzj The new version of pyside is out and it has the corrected grammar. Since we update from pyside 6.2... to 6.7... the types have become much more defined and consistent. As a result, I had to correct 200 mypy issues. The remaining mypy issues are from your code. How do we continue?

@SteffenBrinckmann Is there any reason why these errors are detected now by myPy and it seems to be all related to QT, did we change some QT related configuration for myPy? Or is this also a problem associated with the latest version of pySide?

[SteffenBrinckmann]

@jmurugan-fzj Yes, it it qt related and before the definitions of qt were not as well as they are now. For me 90% were true issues.

[jmurugan-fzj]

@SteffenBrinckmann Okay, I am working presently on feature/10-show-completed-module, as soon as I finalize this, I can work on this, is this fine? If so, could you please move it back to draft, as soon as I begin, I shall move it back!

[jmurugan-fzj]

@jmurugan-fzj Yes, it it qt related and before the definitions of qt were not as well as they are now. For me 90% were true issues.

@SteffenBrinckmann I see some error with the .venv setup for the pasta project and this is because of the old version (Python 3.10.12) of python in my system.

I would like to upgrade the Ubuntu (22.04.1-Ubuntu) also to the same version as you have which might also bring the latest version of python. Could you please provide the version of ubuntu & python you have, so that I can ask Ramadan to upgrade it soon too?

Do not want to upgrade the python manually, since there are chances that this could mess up my existing setup: link

[SteffenBrinckmann]

@jmurugan-fzj I use Ubuntu 24.04 and python 3.12

[SteffenBrinckmann]

As you can see from the many mypy commits, my system did not give the same errors as the GitHub action. The GitHub action is the measure, and I repaired, committed, checked again until there was success

[jmurugan-fzj]

As you can see from the many mypy commits, my system did not give the same errors as the GitHub action. The GitHub action is the measure, and I repaired, committed, checked again until there was success

@SteffenBrinckmann Thanks for the information, I would see this as soon as my setup is ready!

[jmurugan-fzj]

@SteffenBrinckmann I had corrected the myPy errors along with the tests, quickly tested the corrected features too and they seem to be working fine, if you are confident about the other features in PASTA, please go ahead and do the merge, but in any-case, I think it's always better to do a whole feature test with the latest versions (Ubuntu 24.04 LTS & Python 3.12.4) of the dependencies!

[jmurugan-fzj]

@SteffenBrinckmann Would you like to merge this PR or want to wait a bit more? I am thinking to make changes on a new branch (for #301) based on this one, because my setup is also upgraded to the new python version and so on... If you have a different thought, please let me know, I shall wait until this PR is finalized..