-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dataverse): implement data upload history module #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmurugan-fzj
commented
Jun 11, 2024
•
edited
Loading
edited
- Added get_paginated_upload_model_query_results & create_query_index to database_api in order to query the upload models in a paginated fashion.
- Added created_date_time field to upload_model.py. Adapted the other modules accordingly.
- Adapted the completed_uploads.py to use the paginate api to load the data whenever the user scrolls to the bottom end.
- Restructured the initialize_config_document method to also populate the project_upload_items from data hierarchy during the initialization (default setting is to all items selected during the initialization).
- Other minor modifications in completed_upload_task.ui & completed_uploads_base.ui.
- Corrected the truncation bug for the project name which is passed in while creating the DataUploadTask instances.
- Adapted the completed_uploads.py module to display the project name truncated and have the full name in the tooltip.
- Modified the existing tests and added new tests.
- Added component tests for completed_uploads.py
- Minor fixes.
… action links. - Added show functionality to the completed_uploads.py module.
… to database_api in order to query the upload models in a paginated fashion. - Added created_date_time field to upload_model.py. Adapted the other modules accordingly. - Adapted the completed_uploads.py to use the paginate api to load the data whenever the user scrolls to the bottom end. - Other minor modifications in completed_upload_task.ui & completed_uploads_base.ui. - Modified the existing tests and added new tests.
- Modified the existing tests and added new tests for the changes.
- Minor fixes.
…e & re-opens of the completed_uploads.py module.
… the ELN file generation failure. - Also enabled the proper logging for the failure scenarios. Adapted the necessary tests.
… the project_upload_items from data hierarchy. - Adapted the other modules as well as per the changes. - Added more tests and adapted existing ones.
…n while creating the DataUploadTask instances. - Adapted the completed_uploads.py module to display the project name truncated and have the full name in the tooltip. - Corrected and adapted the tests.
@SteffenBrinckmann Could you please quickly review if you are online anytime? |
SteffenBrinckmann
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.