Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug if meta not in extractor #40

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Bug if meta not in extractor #40

merged 4 commits into from
Sep 18, 2023

Conversation

SteffenBrinckmann
Copy link
Contributor

create safeguard that prevents crashing

@SteffenBrinckmann SteffenBrinckmann added the bug Something isn't working label Sep 13, 2023
@SteffenBrinckmann SteffenBrinckmann self-assigned this Sep 13, 2023
@SteffenBrinckmann
Copy link
Contributor Author

@jmurugan-fzj Can you understand why this is crashing? The fix is two lines in a code that is not even used in any tests, as far as I understand.

@jmurugan-fzj
Copy link
Contributor

@jmurugan-fzj Can you understand why this is crashing? The fix is two lines in a code that is not even used in any tests, as far as I understand.

@SteffenBrinckmann Please do the following to make the test pass,

In the file, test_ontology_config_utility_functions.py

Line number 79: Change contents = {} to contents = {"-version": 2}

@SteffenBrinckmann
Added 60sec timeout to url-requests
70f1764 
- example data uses smaller wikipedia image
@SteffenBrinckmann
linting
75d3cf4
@SteffenBrinckmann
Copy link
Contributor Author

@jmurugan-fzj
I added a timeout to all urlrequests and the default example uses a smaller wikipedia image
These things are related, since they all improve the installation of Pasta: hence one PR is appropriate

This was referenced Sep 15, 2023
Closed
Closed
@jmurugan-fzj
Copy link
Contributor

@SteffenBrinckmann Could you please make sure that the PR is associated with a github bug? I did not understand this bug clearly, specially the steps to reproduce it..!

jmurugan-fzj
jmurugan-fzj approved these changes Sep 18, 2023
View reviewed changes
pasta_eln/fixedStringsJson.py

"x0": {"link":"", "label":"Projects", "prop":[
"x0": {"link":"", "label":"Projects", "prop": {"default": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please merge the changes from main branch? so that I can avoid reviewing such outdated files..

@SteffenBrinckmann SteffenBrinckmann merged commit 27adec9 into main Sep 18, 2023
@SteffenBrinckmann SteffenBrinckmann deleted the bug_if_meta_not_in_extractor branch September 22, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmurugan-fzj jmurugan-fzj jmurugan-fzj approved these changes

Assignees

@SteffenBrinckmann SteffenBrinckmann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteffenBrinckmann @jmurugan-fzj