Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Squiz: normalise indentation of closing CDATA tags #361

Merged

Conversation

jaymcp
Copy link
Contributor

@jaymcp jaymcp commented Feb 23, 2024

Description

This PR updates the documentation for the Squiz standard, correcting the indentation of the closing CDATA tags.

Suggested changelog entry

Normalise indentation of CDATA tags in documentation for Squiz standard

Related issues/external references

Per discussion in #352 (comment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonmcp Thanks for doing this! It really helps to make things more consistent.

@jrfnl jrfnl enabled auto-merge February 24, 2024 09:22
@jrfnl jrfnl merged commit 228e71a into PHPCSStandards:master Feb 24, 2024
40 checks passed
@jaymcp jaymcp deleted the docs/squiz/standardise-indentation branch February 26, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants