Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: normalise indentation of CDATA tags in sniff documentation #365

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

jaymcp
Copy link
Contributor

@jaymcp jaymcp commented Feb 26, 2024

Description

This PR normalises CDATA tag indentation in sniff documentation.
The original intention was to open separate PRs for changes to every standard, but it was primarily Squiz that was affected, which was addressed in #361. These are the last few instances of incorrect indentation that I found across all other standards.

Suggested changelog entry

Normalise indentation of CDATA tags in sniff documentation.

Related issues/external references

Per discussion #352 (comment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonmcp for verifying all that and tidying it up!

@jrfnl jrfnl added this to the 3.9.1 milestone Feb 27, 2024
@jrfnl jrfnl merged commit 631466b into PHPCSStandards:master Feb 27, 2024
40 checks passed
@jaymcp jaymcp deleted the docs/standardise-indentation branch March 4, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants