Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI][Refactoring] Constrain direct wallet access from the GUI in a single place #2293

Merged
merged 12 commits into from
Apr 16, 2021
Merged

[GUI][Refactoring] Constrain direct wallet access from the GUI in a single place #2293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
422d662
[Refactoring] Move processBalanceChangeInternal to walletModel
random-zebra Apr 2, 2021
cebc900
[Refacotring] Make WalletModel::getBalances private
random-zebra Apr 3, 2021
bffe2c5
[BUG] Incorrect usage of pwalletMain inside GUI walletModel
random-zebra Apr 2, 2021
50867e2
[Cleanup][Trivial] Remove unused argument in NotifyKeyStoreStatusChanged
random-zebra Apr 2, 2021
733fbc3
[Trivial] Cleanup walletmodel includes
random-zebra Apr 2, 2021
87d4979
[Refactoring] Move SST / custom fee handling to walletmodel
random-zebra Apr 2, 2021
4ca5a2a
[Refactoring][GUI] GetAvailableP2CSCoins inside walletModel
random-zebra Apr 2, 2021
beb1cf6
[Refactoring][GUI] remove pwalletMain direct access in mnmodel
random-zebra Apr 2, 2021
5afa2ea
[Cleanup] Kill MultiSend for good
random-zebra Apr 3, 2021
1a87c44
[Refactoring] Add getSaplingAddressString to walletModel
random-zebra Apr 3, 2021
7ec1c65
[Refactoring][GUI] Remove last remaining pwalletMain calls in the GUI
random-zebra Apr 3, 2021
012de60
[Cleanup] Remove unused optionsdialog
random-zebra Apr 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/Makefile.qt.include
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ QT_FORMS_UI = \
qt/forms/helpmessagedialog.ui \
qt/forms/intro.ui \
qt/forms/openuridialog.ui \
qt/forms/optionsdialog.ui \
qt/forms/rpcconsole.ui \
qt/pivx/forms/loadingdialog.ui \
qt/pivx/forms/snackbar.ui \
Expand Down Expand Up @@ -59,8 +58,6 @@ QT_FORMS_UI = \
qt/pivx/settings/forms/settingsfaqwidget.ui \
qt/pivx/settings/forms/settingsinformationwidget.ui \
qt/pivx/settings/forms/settingsmainoptionswidget.ui \
qt/pivx/settings/forms/settingsmultisenddialog.ui \
qt/pivx/settings/forms/settingsmultisendwidget.ui \
qt/pivx/settings/forms/settingssignmessagewidgets.ui \
qt/pivx/settings/forms/settingswalletoptionswidget.ui \
qt/pivx/settings/forms/settingswalletrepairwidget.ui \
Expand All @@ -87,7 +84,6 @@ QT_MOC_CPP = \
qt/moc_macnotificationhandler.cpp \
qt/moc_notificator.cpp \
qt/moc_openuridialog.cpp \
qt/moc_optionsdialog.cpp \
qt/moc_optionsmodel.cpp \
qt/moc_peertablemodel.cpp \
qt/moc_paymentserver.cpp \
Expand Down Expand Up @@ -148,8 +144,6 @@ QT_MOC_CPP = \
qt/pivx/settings/moc_settingsfaqwidget.cpp \
qt/pivx/settings/moc_settingsinformationwidget.cpp \
qt/pivx/settings/moc_settingsmainoptionswidget.cpp \
qt/pivx/settings/moc_settingsmultisenddialog.cpp \
qt/pivx/settings/moc_settingsmultisendwidget.cpp \
qt/pivx/settings/moc_settingssignmessagewidgets.cpp \
qt/pivx/settings/moc_settingswalletoptionswidget.cpp \
qt/pivx/settings/moc_settingswalletrepairwidget.cpp \
Expand Down Expand Up @@ -195,7 +189,6 @@ BITCOIN_QT_H = \
qt/networkstyle.h \
qt/notificator.h \
qt/openuridialog.h \
qt/optionsdialog.h \
qt/optionsmodel.h \
qt/paymentrequestplus.h \
qt/paymentserver.h \
Expand Down Expand Up @@ -269,8 +262,6 @@ BITCOIN_QT_H = \
qt/pivx/settings/settingsfaqwidget.h \
qt/pivx/settings/settingsinformationwidget.h \
qt/pivx/settings/settingsmainoptionswidget.h \
qt/pivx/settings/settingsmultisenddialog.h \
qt/pivx/settings/settingsmultisendwidget.h \
qt/pivx/settings/settingssignmessagewidgets.h \
qt/pivx/settings/settingswalletoptionswidget.h \
qt/pivx/settings/settingswalletrepairwidget.h \
Expand Down Expand Up @@ -511,7 +502,6 @@ BITCOIN_QT_BASE_CPP = \
qt/intro.cpp \
qt/networkstyle.cpp \
qt/notificator.cpp \
qt/optionsdialog.cpp \
qt/optionsmodel.cpp \
qt/peertablemodel.cpp \
qt/platformstyle.cpp \
Expand Down Expand Up @@ -592,8 +582,6 @@ BITCOIN_QT_WALLET_CPP = \
qt/pivx/settings/settingsfaqwidget.cpp \
qt/pivx/settings/settingsinformationwidget.cpp \
qt/pivx/settings/settingsmainoptionswidget.cpp \
qt/pivx/settings/settingsmultisenddialog.cpp \
qt/pivx/settings/settingsmultisendwidget.cpp \
qt/pivx/settings/settingssignmessagewidgets.cpp \
qt/pivx/settings/settingswalletoptionswidget.cpp \
qt/pivx/settings/settingswalletrepairwidget.cpp \
Expand Down
3 changes: 0 additions & 3 deletions src/qt/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ SET(QT_SOURCES
${CMAKE_CURRENT_SOURCE_DIR}/intro.cpp
${CMAKE_CURRENT_SOURCE_DIR}/networkstyle.cpp
${CMAKE_CURRENT_SOURCE_DIR}/notificator.cpp
${CMAKE_CURRENT_SOURCE_DIR}/optionsdialog.cpp
${CMAKE_CURRENT_SOURCE_DIR}/optionsmodel.cpp
${CMAKE_CURRENT_SOURCE_DIR}/peertablemodel.cpp
${CMAKE_CURRENT_SOURCE_DIR}/platformstyle.cpp
Expand Down Expand Up @@ -164,8 +163,6 @@ SET(QT_SOURCES
${CMAKE_CURRENT_SOURCE_DIR}/pivx/settings/settingsfaqwidget.cpp
${CMAKE_CURRENT_SOURCE_DIR}/pivx/settings/settingsinformationwidget.cpp
${CMAKE_CURRENT_SOURCE_DIR}/pivx/settings/settingsmainoptionswidget.cpp
${CMAKE_CURRENT_SOURCE_DIR}/pivx/settings/settingsmultisenddialog.cpp
${CMAKE_CURRENT_SOURCE_DIR}/pivx/settings/settingsmultisendwidget.cpp
${CMAKE_CURRENT_SOURCE_DIR}/pivx/settings/settingssignmessagewidgets.cpp
${CMAKE_CURRENT_SOURCE_DIR}/pivx/settings/settingswalletoptionswidget.cpp
${CMAKE_CURRENT_SOURCE_DIR}/pivx/settings/settingswalletrepairwidget.cpp
Expand Down
Loading