[Sapling][Refactoring] Save wallet reference inside SaplingOperation #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transaction builder should be initialized and set only when the sapling_operation is constructed.
Save a wallet reference when initializing sapling_operation, and pass it to the txbuilder (so we are sure that the keystore used to sign the keys belongs to the wallet used to retrieve the inputs).
furszy
reviewed
Apr 9, 2021
furszy
approved these changes
Apr 10, 2021
Fuzzbawls
approved these changes
Apr 14, 2021
|
Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complements #2293, trying to achieve the same goal on the sapling code (remove all rogue accesses to
pwalletMain).Save a pointer to a wallet inside
SaplingOperation, initialized in the constructor, and passed directly to theTransactionBuilder(which needs a keystore to produce signatures for the transparent inputs).