Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sapling][Refactoring] Save wallet reference inside SaplingOperation #2294

Merged
merged 4 commits into from
Apr 14, 2021
Merged

[Sapling][Refactoring] Save wallet reference inside SaplingOperation #2294

merged 4 commits into from
Apr 14, 2021

Commits on Apr 3, 2021

  1. [Cleanup] Remove un-used setTxBuilder in sapling_operation 

    The transaction builder should be initialized and set only when the
sapling_operation is constructed.
    @random-zebra
    random-zebra committed Apr 3, 2021
    Configuration menu
    Copy the full SHA
    74a1592 View commit details
    Browse the repository at this point in the history

  2. [Refactoring] Initialize txbuilder inside sapling_operation 

    Save a wallet reference when initializing sapling_operation, and pass it
to the txbuilder (so we are sure that the keystore used to sign the keys
belongs to the wallet used to retrieve the inputs).
    @random-zebra
    random-zebra committed Apr 3, 2021
    Configuration menu
    Copy the full SHA
    80054f7 View commit details
    Browse the repository at this point in the history

  3. [Refactoring] Remove all pwalletMain direct access in sapling_operation

    @random-zebra
    random-zebra committed Apr 3, 2021
    Configuration menu
    Copy the full SHA
    c4853b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2021

  1. [Trivial] Initialize wallet pointers to nullptr

    @random-zebra
    random-zebra committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    b1e1f4e View commit details
    Browse the repository at this point in the history