-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactoring] Completed migration of uint* classes to blob #2314
Conversation
2ef469a
to
90059b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work conclusion!
Code review ACK 90059b4
Will run it some time on mainnet before giving the final approval.
90059b4
to
9ad9983
Compare
9ad9983
to
7bbbae3
Compare
Rebased again. |
…SG usage for dynamic messages. 8ff6fa2 [test] validation_block_tests: New ASSERT_WITH_MSG to print dynamic error messages. (furszy) Pull request description: Bug discovered checking GA failing reason in #2314 --> [job](https://github.com/PIVX-Project/PIVX/pull/2314/checks?check_run_id=2509761057) Essentially, `BOOST_ASSERT_MSG` only prints static string messages. As we are inputting a dynamic message, the value isn't being printed if the test fails. So, have added a new function `ASSERT_WITH_MSG(cond, msg)` to support dynamic error messages. ACKs for top commit: random-zebra: ACK 8ff6fa2 and merging... (this means another rebase for #2360) Tree-SHA512: a47c8f94a497696a5bbb2b09b01f8dd1711b898a3d363211d12c79fd92b67a4f4d255a2c97ae192e17ccab706a604e16140a18bc7ea3f3539e8fad4559351902
- delete old uint256.h/uint256.cpp files - delete old uint512.h - rename files blob_uint256.h/blob_uint256.cpp --> uint256.h/uint256.cpp - rename class blob_uint256 --> uint256 - add uint160/512 blob implementation inside uint256.* files - move UintToArith/ArithToUint to arith_uint256.cpp
7bbbae3
to
722759d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have been running this since the last rebase and all good, ACK 722759d
This will have few conflicts with #2352. They are both a pain to rebase / re-review / re-test, so am not sure which one we want to merge first. Pinging @Fuzzbawls |
I'm ok with prioritizing this over #2352 and did some initial code review already, will finish my review later today but looking good so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 722759d
Finally out of an old rabbit hole, started with #1395, #1414, and #2092.
As per title, complete the migration:
arith_uint*
classes whenever the uint is interpreted as a numberuint*
classes child ofbase_blob
, and use it everywhere elseblob_uint*
temporary class