[test] validation_block_tests: Correcting BOOST_ASSERT_MSG usage for dynamic messages. #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror messages. BOOST_ASSERT_MSG only prints static string messages and that isn't enough to understand possible problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug discovered checking GA failing reason in #2314 --> job
Essentially,
BOOST_ASSERT_MSGonly prints static string messages. As we are inputting a dynamic message, the value isn't being printed if the test fails.So, have added a new function
ASSERT_WITH_MSG(cond, msg)to support dynamic error messages.