Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] [Qt] RPC-Console nested commands documentation #2372

Merged
merged 2 commits into from
May 11, 2021

Conversation

random-zebra
Copy link

Follow up to #2282

First commit backports bitcoin#11698, adding:

  • a line to the initial message text at the top of the debug console
  • a pseudo-command help-console which is hooked after parsing the request, but before executing the RPC thread

Second commit updates the release notes.

Luke Mlsna and others added 2 commits May 9, 2021 22:45
     - Added `help-console` to the list of autocompletion strings
     - Implemented requested changes to help message:
       - Added an example that uses access-by-index
`getblock(getblockhash(0) true)[tx][0]`
       - Replace "bracketed syntax" to "parenthesized syntax" where
applicable
       - Replace "separate" with "delimit"
       - Removed `<br>` and `<b>help/help-console</b>` from translation
strings, since these parts don't change between languages
       - Changed examples to be based off `getblock 0` so they will work
even with pruned/no blockchain and `disablewallet` if copied and pasted
       - Clarified syntax for queries of named/unnamed result objects.
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK d8fe6bf

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d8fe6bf

@random-zebra random-zebra merged commit eeb1632 into PIVX-Project:master May 11, 2021
furszy added a commit that referenced this pull request Aug 19, 2021
47607df [Qt] Console: don't allow empty arguments when using the comma-syntax (random-zebra)
af215ef [Qt] Console: allow empty arguments (random-zebra)

Pull request description:

  #2372 broke the support for empty arguments `""` (which is required as first argument of `sendmany`).
  Backport the fix from bitcoin#9329

  Thanks to @NoobieDev12 for reporting this bug.

ACKs for top commit:
  furszy:
    Nice catch👌, ACK 47607df
  Fuzzbawls:
    ACK 47607df

Tree-SHA512: 9ebcce3fbcb10856fc0a586365a9f0c4a3bbed5df571f21b37a143a882ab937b0fdf0502d1ba39e015cc0f745b07ed78fa8eb547110d0e53401f0d88af89cba1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants