[GUI] RPC-Console support nested commands and simple value queries #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands can be executed with bracket syntax, example: `getwalletinfo()`. Commands can be nested, example: `sendtoaddress(getnewaddress(), 10)`. Simple queries are possible: `listunspent()[0][txid]` Object values are accessed with a non-quoted string, example: [txid]. Fully backward compatible. `generate 101` is identical to `generate(101)` Result value queries indicated with `[]` require the new brackets syntax. Comma as argument separator is now also possible: `sendtoaddress,<address>,<amount>` Space as argument separator works also with the bracket syntax, example: `sendtoaddress(getnewaddress() 10) No dept limitation, complex commands are possible: `decoderawtransaction(getrawtransaction(getblock(getbestblockhash())[tx][0]))[vout][0][value]`
Fuzzbawls
previously approved these changes
Apr 4, 2021
There was a problem hiding this comment.
ACK d763267, but some further cleanup because of your second commit is possible.
Feel free to cherry-pick Fuzzbawls@d9e530d, or i can PR it after this is merged
Fuzzbawls
added
the
Needs Release Notes
With the GUI's RPC execution code being now de-duplicated, we can do some additional cleanup for CMake builds and a no-longer-needed `rpcconsole.moc` include.
Yup, nice 👍 Cherry-picked. |
Fuzzbawls
approved these changes
Apr 5, 2021
|
Nice PR, and even nicer code duplication refactoring! ☕ . Only for devs hehe. Have been playing with it a bit, something that would be great to add is a proper "Method not found" error description. For example, typing |
furszy
approved these changes
Apr 7, 2021
random-zebra
added a commit
that referenced
this pull request
Apr 9, 2021
7f4b2a4 [RPC] Return method name with 'Method not found' errors (random-zebra) Pull request description: Simple change, to address the feature requested by @furszy here: #2282 (comment)  ACKs for top commit: furszy: Code review ACK 7f4b2a4 Fuzzbawls: ACK 7f4b2a4 Tree-SHA512: fdc6e62c469995931b996edbc325e96f7fa485b1a001b291a411582b2799df91bf711a5d913a2d3bbaacdb1776ddf0b837ac2ae2f41b6e53419871d4d811ecee
random-zebra
removed
the
Needs Release Notes
random-zebra
added a commit
that referenced
this pull request
May 11, 2021
d8fe6bf [Doc] Add new GUI RPC-console syntax to release notes (random-zebra) eced57b Add help-console command to Qt debug console (Luke Mlsna) Pull request description: Follow up to #2282 First commit backports bitcoin#11698, adding: - a line to the initial message text at the top of the debug console - a pseudo-command `help-console` which is hooked after parsing the request, but before executing the RPC thread Second commit updates the release notes. ACKs for top commit: furszy: utACK d8fe6bf Fuzzbawls: ACK d8fe6bf Tree-SHA512: df415a27acb587535dfdc8775bacb231d435566bdfb18ea71863212999cf78d139b9b1eaceead5c573ace5203416d2f9392f9179ccd56b3eda1e2ab9fc3ad772
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports a pretty cool feature for the GUI rpc-console from bitcoin#7783, which makes testing much faster, removing the need for copying/pasting the outputs of the commands.