[test] sapling_wallet_nullifiers.py whitelist peers to speed up tx relay. #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
changed the title
Fuzzbawls
approved these changes
Nov 13, 2021
furszy
added a commit
that referenced
this pull request
Nov 19, 2021
…allet_nullifiers 0f79bdc [QA] Fix intermittent mempool sync failures in sapling_wallet_nullifiers (random-zebra) Pull request description: Still (somewhat frequent) mempool sync failures in this test, even after #2633. This is because `node1` might still be in IBD when he receives the first tx INV message, and, with #2611, nodes no longer send (non-block) getdata requests during initial sync. ACKs for top commit: furszy: great catch, ACK 0f79bdc. Fuzzbawls: ACK 0f79bdc Tree-SHA512: a3f3b81848893803ba04e93d605d7d6accb2b2a28c62a8d7dbd09ae5513111c917c46f1e30eccacdf9b6ac9f1caf06ff4383fd0071d55133f49e8798e68933d4
furszy
added a commit
that referenced
this pull request
Dec 30, 2021
…peed up tx relay. 50dfb63 test: sapling_key_import_export.py whitelist peers to speed up tx relay. (furszy) Pull request description: Same rationale as #2633, whitelist peers so the trickle mechanism does not delay the mempool txs relay. Saw this test failing here https://github.com/PIVX-Project/PIVX/runs/4643010485?check_suite_focus=true . ACKs for top commit: random-zebra: utACK 50dfb63 Fuzzbawls: ACK 50dfb63 Tree-SHA512: b08c6975729bbc7bdc3c40055904aeed715d4ee178e649aef94778e99d628af7b56c1b8e99a3aa916cbddcf5b8665bf1586d675b0c795173a3729dd6a701ffe8
random-zebra
added a commit
that referenced
this pull request
Jan 29, 2022
…up tx relay. 2dcb5c2 test: wallet_zapwallettxes.py whitelist peers to speed up tx relay. (furszy) Pull request description: Same rationale as #2633, whitelist peers so the trickle mechanism does not delay the mempool txs relay. Saw it failing for this reason in master: https://github.com/PIVX-Project/PIVX/runs/4821849471?check_suite_focus=true ACKs for top commit: random-zebra: ACK 2dcb5c2 Fuzzbawls: ACK 2dcb5c2 Tree-SHA512: ec61598e78108f87d12f1485cc5c99b125c49044fc1a72b015839616c4dcbe35c30770a34a71da3b76279d6f32d09053e13d9aa43172743c166e5e80d418a477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have seen this test failing in GA due a not synchronized mempool across nodes. Which has nothing to do with the test purpose, so this will let every node by-pass the trickle logic and directly relay the known transactions.