[QA] Fix intermittent mempool sync failures in sapling_wallet_nullifiers #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
approved these changes
Nov 19, 2021
furszy
added a commit
that referenced
this pull request
Dec 18, 2021
bc33da8 [QA] Use single node in sapling_changeaddresses (random-zebra) Pull request description: Same problem as #2638, on a different test (GA failed run [here](https://github.com/PIVX-Project/PIVX/runs/4383720230)). Since there's no need to use two nodes to perform this test, instead of adding the missing `sync_blocks`/`sync_mempools` calls, just remove the second node (which also speeds the test up). ACKs for top commit: furszy: nice one, ACK bc33da8 Fuzzbawls: ACK bc33da8 Tree-SHA512: 9ce2753da17c2002b84a476d2fec0d450109ddfc593935286594a2829d705d220fc888e480499c3c14bd0f933ad91b8f3d5f7c0523656c196c0d973ee00cb1c0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still (somewhat frequent) mempool sync failures in this test, even after #2633.
This is because
node1might still be in IBD when he receives the first tx INV message, and, with #2611, nodes no longer send (non-block) getdata requests during initial sync.