[GUI][Cleanup] Stop translating placeholder strings #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This string can be generated dynamically and using the current network's display unit. `kB` is also universally accepted in most languages so no translation is needed.
Stop translating the `PIV` string literal, and use the current network's display unit.
Cleans up the CSV export UI to reduce the number of strings being translated.
After the previous commits, net result is 3 new strings and 75 removed strings
|
JSYK, the failing GA job is solved in #2634. |
furszy
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop passing placeholder strings that will never be shown in the GUI to Transifex. This includes many unused
WindowTitleinstances, as well as dynamic strings that are always set programmatically.Additionally, we can simplify the fee-per-kb text by not passing a string literal, and instead use a dynamic string that doesn't need translating. The same goes for the payment request UI, where we can simply insert the current network's acronym (
PIVortPIV, for example) instead of a static string that doesn't need translation.Lastly, the export UI had some strings that were either too vague, or multiple strings that described the same thing.
Net difference in number of strings is 3 new and 75 removed.
As we base the inclusion of a translation language into the wallet client on it's translation completion percentage; getting rid of these placeholder strings, as well as unifying multiple strings to describe the same thing, will ultimately improve the translation process and make it easier for a language to reach the 80% translation threshold for inclusion.