Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI][Cleanup] Stop translating placeholder strings #2635

Merged
merged 6 commits into from
Nov 18, 2021
Merged

[GUI][Cleanup] Stop translating placeholder strings #2635

merged 6 commits into from
Nov 18, 2021

Commits on Nov 10, 2021

  1. Qt: Stop translating placeholder windowTitles

    @Fuzzbawls
    Fuzzbawls committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    d169aa2 View commit details
    Browse the repository at this point in the history

  2. Qt: Stop translating other placeholder strings

    @Fuzzbawls
    Fuzzbawls committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    1ac3c44 View commit details
    Browse the repository at this point in the history

  3. Qt: Don't use a string literal for custom fee PIV/kB label 

    This string can be generated dynamically and using the current network's
 display unit. `kB` is also universally accepted in most languages so no
  translation is needed.
    @Fuzzbawls
    Fuzzbawls committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    ac5e858 View commit details
    Browse the repository at this point in the history

  4. Qt: Use current network's display unit in payment request UI 

    Stop translating the `PIV` string literal, and use the current network's
 display unit.
    @Fuzzbawls
    Fuzzbawls committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    dc45153 View commit details
    Browse the repository at this point in the history

  5. Qt: Unify translated strings in export UI 

    Cleans up the CSV export UI to reduce the number of strings being
translated.
    @Fuzzbawls
    Fuzzbawls committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    f436b71 View commit details
    Browse the repository at this point in the history

  6. [GUI] Make translate 

    After the previous commits, net result is 3 new strings and 75 removed
strings
    @Fuzzbawls
    Fuzzbawls committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    40f2f12 View commit details
    Browse the repository at this point in the history