[Backport] 5.4.0 backports #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-BEGIN VERIFY SCRIPT- sed -i -e 's/boost::optional/Optional/g' -e 's/boost::none/nullopt/g' -e 's?#include <boost/optional.hpp>?#include "optional.h"?g' src/sapling/*.h src/sapling/*.cpp src/util/system.h src/wallet/test/wallet_shielded_balances_tests.cpp; -END VERIFY SCRIPT- Github-Pull: bitcoin#2642 Rebased-From: d74cd79
Github-Pull: bitcoin#2642 Rebased-From: 525c2e7
Github-Pull: bitcoin#2646 Rebased-From: b09422f
>>> based on bitcoin/bitcoin@1fabd59 Github-Pull: bitcoin#2646 Rebased-From: 33ddc5d
by moving GetLastCheckpoint() to validation.cpp Github-Pull: bitcoin#2643 Rebased-From: 9b97cf0
by moving CCheckpointData into chainparams.h (as per bitcoin/bitcoin@f0deec5) Github-Pull: bitcoin#2643 Rebased-From: 50fb779
by moving GetKeyIDFromUTXO to blocksignature.cpp, which is the only place using it Github-Pull: bitcoin#2644 Rebased-From: e55b0dc
Github-Pull: bitcoin#2661 Rebased-From: d281cde
Note locking is not yet implemented, as such there is no reason to show any of the locking related actions in the coin control dialog. Github-Pull: bitcoin#2662 Rebased-From: f05bd1b
Cleans up some instances of duplicate item names, which results in build-time warnings. Github-Pull: bitcoin#2663 Rebased-From: 943159e
Github-Pull: bitcoin#2663 Rebased-From: 7483ef4
Github-Pull: bitcoin#2671 Rebased-From: d3ca538
…reward records. Github-Pull: bitcoin#2671 Rebased-From: 8be73ac
When there are enough proposals to need the GUI to scroll down to see them all, the location of the tooltip menu gets skewed to the point of it not being visible. This is because it's location was being based on the initial position of the proposal card, even for off-screen ones. This fixes the issue by taking the scrollarea's vertical scrollbar value into consideration. Github-Pull: bitcoin#2664 Rebased-From: 4ba2c4c
Github-Pull: bitcoin#2670 Rebased-From: 155ad6d
Previously, the governance nav button was not showing the same background color as the rest of the nav buttons. This fixes it to be the same as the others. Also slightly increase the size of the icon. Github-Pull: bitcoin#2665 Rebased-From: b801219
Github-Pull: bitcoin#2672 Rebased-From: 948c760
Github-Pull: bitcoin#2672 Rebased-From: 9d86871
This resolves a bug introduced in 66aa1d5 where, if when responding to a series of transaction requests in a getdata we hit the send buffer limit and set fPauseSend, we will skip one transaction per call to ProcessGetData. Bug found by Cory Fields (@theuni). Github-Pull: bitcoin#2677 Rebased-From: 3355026
no functional change. Github-Pull: bitcoin#2659 Rebased-From: fd7d569
if we received for example a single proposal +50 seconds ago, then once the budget sync starts (right after this call), it will look like the sync is finished. Will not wait to receive any budget data and declare the sync over. Github-Pull: bitcoin#2659 Rebased-From: 7349750
MNW initial sync is mostly for historical reasons, get +20k items per peer (+120k items total for the previous threshold of 6) is a high amount of duplicated data relayed over the wire. 89k is still very high but.. it's something that we have to live with until v6.0. Github-Pull: bitcoin#2659 Rebased-From: 7020310
…s flow. As we are increase the `RequestedMNAttempt` right after calling `SwitchToNextAsset()`, the mn list sync starts with an invalid extra sync attempt. Github-Pull: bitcoin#2659 Rebased-From: 2c3b0e8
Before, this function was being totally skipped for the tiertwo_networksync dispatcher function. The dispatcher internally processes `syncstatusaccount` messages and return true, which means that the message was processed, there by, it was never reaching the `masternodeSync.ProcessMessage` call in net_processing. Github-Pull: bitcoin#2659 Rebased-From: ae28000
…ngle budget finalization. Neither block them if it's us who started the budget sync process. Co-authored-by: random-zebra <random.zebra@protonmail.com> Github-Pull: bitcoin#2659 Rebased-From: 5f596b8
…ed to broadcast an inv if the peer is asking for the item directly..) and stop walking through the two maps (budgets and proposals), locking their mutexes, when the peer is requesting a single proposal/budfin. Github-Pull: bitcoin#2659 Rebased-From: 31e40a4
Github-Pull: bitcoin#2659 Rebased-From: 4864739
…al vote reception and single finalization sync based on an orphan finalization vote. Github-Pull: bitcoin#2659 Rebased-From: 32196b1
…a single vote, discarding the previous stored item every time that a new orphan arrives. Blocking any follow-up reception of the orphan votes that were discarded, prohibiting its connection forever. Github-Pull: bitcoin#2659 Rebased-From: 62e9f5e
…(1) single items sync requests and (2) full budget sync requests. Github-Pull: bitcoin#2659 Rebased-From: 62ae606
Github-Pull: bitcoin#2659 Rebased-From: d04f5be
Github-Pull: bitcoin#2659 Rebased-From: 51e85ff
Github-Pull: bitcoin#2659 Rebased-From: fa2ab10
…reset. The seen maps are used to answer inventory requests (to get the item serialized without locking the main budget maps mutexes). If they are cleared prior to the full budget invs relay, the node will not be able to respond to any follow-up getdata.. Plus, decrease full budget data relay to be done once per week instead of once every 14 days. Github-Pull: bitcoin#2659 Rebased-From: 34e9c23
Essentially a node dropping the budget data and waiting until any of the connected peers relays the complete budget data once more (this happens every 28 blocks in regtest). Github-Pull: bitcoin#2659 Rebased-From: d60a105
And clear the orphan maps as well. Github-Pull: bitcoin#2659 Rebased-From: 6f79df3
nMaxInbound might very well be 0 or -1, if the user prefers to keep a small number of maxconnections. Note: nMaxInbound of -1 means that the user set maxconnections to 8 or less, but we still want to keep an additional slot for the feeler connection. Github-Pull: bitcoin#2682 Rebased-From: 72dfebb
|
Added 2659, 2677 and 2682. Ready to go now. |
Fuzzbawls
approved these changes
Dec 14, 2021
furszy
added a commit
that referenced
this pull request
Dec 18, 2021
47590ba Doc: v5.4.0 release notes (furszy) Pull request description: Final release notes for the coming v5.4.0 release. Note: #2678 is still pending. ACKs for top commit: random-zebra: utACK 47590ba Fuzzbawls: ACK 47590ba Tree-SHA512: fe4983ee9b3cb32911e373cbedb69d9bf904e0e54e03556e3dc00aff0e1c62ee913fc4e2cde3d0bc1f94553d0c509b65181cf7163034b81a3fa8b34e1b8cd882
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of PRs included: