[GUI][Bug] Don't set a proposal's status to PASSING_NOT_FUNDED prematurely #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`name.toUtf8().size()` is already an `int`, so the cast needs to be for `PROP_NAME_MAX_SIZE`, which is a `size_t`
Fuzzbawls
force-pushed
the
2022_gui-overfunded-proposals
branch
from
55f20c3
to
c844ebf
Compare
|
updated per feedback |
furszy
reviewed
Jan 13, 2022
Simply checking that there are more "yes" votes than "no" votes isn't enough context to determine if a proposal should be in a passing state (`PASSING` or `PASSING_NOT_FUNDED`) clientModel: cache plain masternodes count
Fuzzbawls
force-pushed
the
2022_gui-overfunded-proposals
branch
from
c844ebf
to
52cbb9e
Compare
|
I've extracted out the const qualifier changes as they are not directly tied to the bug that this PR fixes, and there are many more instances of such usage within our codebase that would be better handled in a dedicated PR. |
furszy
previously approved these changes
Jan 23, 2022
src/qt/pivx/proposalcard.cpp
Outdated
Comment on lines
64
to
67
| setStatusAndVotes( tr("Not Passing"), (int)percentageNo); | ||
| } else if (proposalInfo.status == ProposalInfo::PASSING_NOT_FUNDED) { | ||
| cssClassStatus = "card-status-not-passing"; | ||
| setStatusAndVotes( tr("Over Budget"), (int)percentageNo); |
Set a unique label text for proposals that are passing but there aren't enough funds left in the budget to find them.
Fuzzbawls
force-pushed
the
2022_gui-overfunded-proposals
branch
from
52cbb9e
to
8a8e089
Compare
Fuzzbawls
added a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Sep 11, 2022
Followup to PIVX-Project#2717 which was incorrectly marking proposals as Over Budget instead of Not Passing
Fuzzbawls
added a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Sep 17, 2022
Followup to PIVX-Project#2717 which was incorrectly marking proposals as Over Budget instead of Not Passing
Fuzzbawls
added a commit
that referenced
this pull request
Sep 25, 2022
a450ea2 [GUI] Start MN update timer on launch and on governance page. (Fuzzbawls) 2ba665c [GUI] Fix Passing Not Funded logic (Fuzzbawls) Pull request description: Followup to #2717 which was incorrectly marking proposals as Over Budget instead of Not Passing ACKs for top commit: yenachar: ACK a450ea2 Tree-SHA512: e5d2f7da62397328987c941b4544906ad3a161d3501c825188c3723a7cd3d3366a85968e9730353a7e832a1faa46cdb3d2cef413b90cb24f7f2a639c9f66f67c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply checking that there are more "yes" votes than "no" votes isn't
enough context to determine if a proposal should be in a passing state
(
PASSINGorPASSING_NOT_FUNDED)Also, Set a unique label text for proposals that are passing but there aren't
enough funds left in the budget to find them.
Also includes some very light refactoring/cleanup in related files and a compile-time warning fix.
There is some follow-up refactoring to be done, but will do that in a separate PR as it falls out-of-scope for this PR.