Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI][Bug] Don't set a proposal's status to PASSING_NOT_FUNDED prematurely #2717

Merged
merged 5 commits into from
Jan 24, 2022

Commits on Jan 10, 2022

  1. Build: Fix sign comparison in governancemodel.cpp

    `name.toUtf8().size()` is already an `int`, so the cast needs to be for
    `PROP_NAME_MAX_SIZE`, which is a `size_t`
    Fuzzbawls committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    d5aa3e2 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Configuration menu
    Copy the full SHA
    7582276 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2022

  1. Configuration menu
    Copy the full SHA
    2964387 View commit details
    Browse the repository at this point in the history
  2. GUI: Don't set a proposal's status to PASSING_NOT_FUNDED prematurely

    Simply checking that there are more "yes" votes than "no" votes isn't
    enough context to determine if a proposal should be in a passing state
    (`PASSING` or `PASSING_NOT_FUNDED`)
    
    clientModel: cache plain masternodes count
    Fuzzbawls committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    1d28002 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. GUI: Differentiate between not passing and over budget in mini-card

    Set a unique label text for proposals that are passing but there aren't
    enough funds left in the budget to find them.
    Fuzzbawls committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    8a8e089 View commit details
    Browse the repository at this point in the history