Add Array support to Map #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
map-add-array-support
branch
from
3858769 to
d87d2bd
Compare
|
Non-primitive types in maps isn’t something we’ve played with. This implementation does feel like an awkward API in the ActiveRecord sense, however, I don’t have a great alternative to suggest. I wonder if any other AR adapters have tackled this problem and if we can take inspiration from their api implementation? |
|
Thank you for your feedback @danielwestendorf. If you're able to point what makes you feel awkward about the API, I'm happy to try to improve it 🙏 |
vincent-pochet
added a commit
to getlago/lago-api
that referenced
this pull request
Oct 29, 2024
## Context Two pull requests opened on the `clickhouse-active` records repository were merged lately. - PNixx/clickhouse-activerecord#158 - PNixx/clickhouse-activerecord#169 Since now all mandatory pieces that we require to use it in production are here, we can use the official gem rather than the fork. ## Description This PR replaces `gem 'clickhouse-activerecord', git: 'https://github.com/getlago/clickhouse-activerecord.git'` with `gem "clickhouse-activerecord", "~> 1.2.0"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version added support for
Map(Thank you @danielwestendorf!)At Lago, we forked this gem to add support for map but never took the time to open a PR with our change (sorry!). I'm updating our code to use the gem as much as possible. Our implementation was slightly different but very close.
The big missing feature is support for arrays inside maps like
{ key: [1, 2, 3] }, which I'm adding in this PR.We'll be running it in production this week and we'll let you know how it goes.
What do you think @danielwestendorf ? Did you get to work with maps of arrays.