Add support for Map datatype #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Clickhouse Datatype Docs](https://clickhouse.com/docs/en/sql-reference/data-types/map) Adapted from [this commit](0d9db1d) but adapted to be similar to the existing `Array` datatype implementation. The most significant change from the previous implementation and this one is that migrations are defined as such: ```diff -- t.string "field_name", map: :string, null: false ++ t.string "field_name, map: true, null: false ``` This allows us to rely upon the other datatypes already defined as the `@subtype` by specifying the column type in normal rails style.
PNixx
reviewed
Jul 25, 2024
`Code: 26. DB::ParsingException: Cannot parse quoted string: expected opening quote ''', got '"': while converting '{"a":"b"}' to Map(String, String): at row 0: While executing ValuesBlockInputFormat. (CANNOT_PARSE_QUOTED_STRING) (version 23.9.6.20 (official build))`
```ruby
value = {"a"=>"b"}
'{' + value.map { |k, v| "#{quote(k)}: #{quote(v)}" }.join(', ') + '}'
=> "{'a': 'b'}"
JSON.generate(value, quirks_mode: true)
=> "{\"a\":\"b\"}"
```
|
I think this PR needs to bake a bit more. I'm reverting to draft for now. |
|
This has been working well for us. |
syabruk
pushed a commit
to machinio/clickhouse-activerecord
that referenced
this pull request
Aug 19, 2024
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickhouse Datatype Docs
Adapted from this commit but adapted to be similar to the existing
Arraydatatype implementation.