feat: Support map of arrays #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
approved these changes
Aug 20, 2024
vincent-pochet
force-pushed
the
map-add-array-support
branch
from
3858769 to
d87d2bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forked the original gem to add support for the Map data type in ClickHouse. The gem added this yesterday. See PNixx#144
It's important to update because only the latest version supports Rails 7.2.
Unfortunately, we use Map of Arrays, which is not supported yet.
Our implementation and the one in the gem are very close but there are some differences. I proposed to move back to the latest version and add support for Map of Arrays on top of their implementation.
upstreamis a new branch in this repo matching the currentuptream/masterbranch. Opening a branch on our master branch is ugly because there are so many commits and conflicts.The Lago app seems to work with this branch getlago/lago-api#2437
Next step
Once we start using our new implementation in production, we should open a PR to add this feature in the gem 🚀 I'm working on adding tests.