Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default to None #305

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Change default to None #305

merged 1 commit into from
Mar 28, 2024

Conversation

benemer
Copy link
Member

@benemer benemer commented Mar 27, 2024

Since the CLI arguments for deskew and max_range overwrite the config and the default argument for deskew is False, the deskew parameter from the config was never used.

tizianoGuadagnino
tizianoGuadagnino approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@tizianoGuadagnino tizianoGuadagnino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Benedetto ❤️

@nachovizzo nachovizzo merged commit 11c7d97 into main Mar 28, 2024
17 checks passed
@nachovizzo nachovizzo deleted the benedikt/change_deskew_default branch March 28, 2024 09:36
@benemer benemer mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tizianoGuadagnino tizianoGuadagnino tizianoGuadagnino approved these changes

@nachovizzo nachovizzo nachovizzo approved these changes

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benemer @nachovizzo @tizianoGuadagnino