-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change target names #327
Change target names #327
Conversation
This reverts commit 59b5d21.
I think this indicates that we need to revise our beloved build system. I will keep this PR just for the target renaming for now and discuss this offline among us. |
#328 introduce the change in the build system that will also fix FetchContent |
I knew this might happen sooner or later. I think the underlying problem is not the name of the targets but the lack of an installable C++ library. I postponed this always, but I'd say we could now fix this the proper way. Using modern cmake, and relying on exported targets instead of manually adding directories in the current build space A probably outdated example: In summary, I think we should make the C++ library installable, like is the case with all the dependencies we use |
Absolutely agree with @nachovizzo, that should be the proper way. Shall we merge this and open a new branch for the install ? |
I'm fine with it as long as we commit to do it and review it relatively soon I will approve this so I don't block you but please let's revisit this soon. I won't have time in the next weeks to work on this particular build feature |
You got my word. |
In the current setting, if someone will
FetchContent
KISS, there might be conflicts based on target names, ascore
andpipeline
are very common. There is probably another workaround to this, but it makes more sense to remove the aliasing and call every targetkiss_icp_<something>
. This is the safest option that should not fire back later on, I attach here an example of what I am talking about.