Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change target names #327

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Change target names #327

merged 5 commits into from
Apr 17, 2024

Conversation

tizianoGuadagnino
Copy link
Collaborator

In the current setting, if someone will FetchContent KISS, there might be conflicts based on target names, as core and pipeline are very common. There is probably another workaround to this, but it makes more sense to remove the aliasing and call every target kiss_icp_<something>. This is the safest option that should not fire back later on, I attach here an example of what I am talking about.

image

@tizianoGuadagnino
Copy link
Collaborator Author

I think this indicates that we need to revise our beloved build system. I will keep this PR just for the target renaming for now and discuss this offline among us.

@tizianoGuadagnino
Copy link
Collaborator Author

#328 introduce the change in the build system that will also fix FetchContent

@nachovizzo
Copy link
Collaborator

I knew this might happen sooner or later. I think the underlying problem is not the name of the targets but the lack of an installable C++ library.

I postponed this always, but I'd say we could now fix this the proper way. Using modern cmake, and relying on exported targets instead of manually adding directories in the current build space

A probably outdated example:
https://github.com/PRBonn/vdbfusion/blob/main/src/vdbfusion/vdbfusion/cmake/Install.cmake

In summary, I think we should make the C++ library installable, like is the case with all the dependencies we use

@tizianoGuadagnino
Copy link
Collaborator Author

Absolutely agree with @nachovizzo, that should be the proper way. Shall we merge this and open a new branch for the install ?

@nachovizzo nachovizzo added the build Build system changes label Apr 17, 2024
@nachovizzo
Copy link
Collaborator

Absolutely agree with @nachovizzo, that should be the proper way. Shall we merge this and open a new branch for the install ?

I'm fine with it as long as we commit to do it and review it relatively soon

I will approve this so I don't block you but please let's revisit this soon. I won't have time in the next weeks to work on this particular build feature

@tizianoGuadagnino
Copy link
Collaborator Author

You got my word.

@tizianoGuadagnino tizianoGuadagnino merged commit 670e4ab into main Apr 17, 2024
17 checks passed
@tizianoGuadagnino tizianoGuadagnino deleted the tiziano/target_names branch April 17, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants