Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: per sensor instance user configurable priority (replaces uORB priority) #14951

Closed
wants to merge 1 commit into from

Conversation

dagar
Copy link
Member

@dagar dagar commented May 21, 2020

This pull request introduces a configurable priority parameter per sensor instance. It replaces both the existing CAL_{ACC,GYRO,MAG}x_EN parameters and the uORB priority mechanism.

  • new priority parameters CAL_ACCx_PRIO, CAL_GYROx_PRIO, CAL_MAGx_PRIO
 * @value 0   Disabled
 * @value 1   Min
 * @value 25  Very Low
 * @value 50  Low
 * @value 75  Default
 * @value 100 High
 * @value 125 Very High
 * @value 255 Max
  • CAL_ACC_PRIME, CAL_GYRO_PRIME, CAL_MAG_PRIME deleted (these have occasionally caused confusion)
  • TODO: special cases like external mags can be set to a higher priority by default, otherwise initial sensor priority is startup order
  • TODO: add baro cal for priority configuration
  • TODO: migrate CAL_ACCx_EN/CAL_GYROx_EN/CAL_MAGx_EN
  • closes per sensor configurable priority  #14948

I'll come back to this post v1.11 release.

@dagar
Copy link
Member Author

dagar commented May 21, 2020

@julianoes, @bkueng, @RomanBapst - No rush, but I'd like to get your feedback on this idea before I go further.

@dagar
Copy link
Member Author

dagar commented May 21, 2020

We could also consider configuring the order more explicitly rather than a somewhat vague priority.

@RomanBapst
Copy link
Contributor

@dagar Thanks for the quick follow up. This is exactly what I imagined. Let's continue after the release then.

@dagar
Copy link
Member Author

dagar commented May 23, 2020

We could also consider configuring the order more explicitly rather than a somewhat vague priority.

This might be more awkward dealing with conflicts or gaps. I'll stick with the priority levels.

@dagar
Copy link
Member Author

dagar commented Jun 30, 2020

This has been rolled into #15235 because it was already addressing some of the missing pieces.

@dagar dagar closed this Jun 30, 2020
@dagar dagar deleted the pr-sensors_priority branch September 4, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

per sensor configurable priority
2 participants