boards/mro/pixracerpro: fix voltage/current monitoring #19757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects the board definition to use the proper polarity for the brick power valid signal, thus allowing the board to detect the battery and monitor it properly.
bkueng
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
The board definition for the Pixracer Pro's brick power valid signal has the wrong polarity.
Describe your solution
This PR corrects the polarity for the signal allowing the battery to be used.
Test data / coverage
Tested using the analog power input socket on a Pixracer Pro and an Mro ACSP4 power module. Verified that the battery is now properly detected, and that the voltage and current readouts can now be correctly calibrated and displayed.
Additional context
Essentially the same fix as #16590