-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow nudging in failsafe Descend mode #21192
Conversation
to map stick input to vehicle tilt consistently and reliably across modes.
and add a function for just pitch roll stick input
- Switching to the first order filter that was previously only in FlightTaskManualAltitude. - Moving the scaling of full stick deflection to radians per second into the class.
and stick input is available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this new feature on a slightly different base branch, and it worked as expected while not causing noticeable changes to other flight modes. And on the side improves code cleanliness. LGTM!
Solved Problem
Being able to nudge the descent in the failsafe mode called Descend using stick input was requested for the following use cases:
which are both not allowed to manually be switched to Altitude mode e.g. by RC override
Solution
StickTiltXY
flight task utility class and reused it in Descend mode.Test coverage