Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nudging in failsafe Descend mode #21192

Merged
merged 7 commits into from
Mar 2, 2023
Merged

Allow nudging in failsafe Descend mode #21192

merged 7 commits into from
Mar 2, 2023

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Feb 24, 2023

Solved Problem

Being able to nudge the descent in the failsafe mode called Descend using stick input was requested for the following use cases:

  • Tethered vehicle
  • VTOL with limited hover time
    which are both not allowed to manually be switched to Altitude mode e.g. by RC override

Solution

  • Put the horizontal stick mapping of Altitude mode in the StickTiltXY flight task utility class and reused it in Descend mode.
  • Unify the blocks for the same stick-mapping strategies. E.g. before the yaw mapping had different filtering and locking logic in Altitude compared to Position mode.

Test coverage

  • Simulation/hardware testing logs: Manual testing of the functionality with SITL gazebo iris of the cases losing GPS without RC override enabled and also losing the altitude estimate on top.

to map stick input to vehicle tilt consistently and reliably across modes.
and add a function for just pitch roll stick input
- Switching to the first order filter that was previously
only in FlightTaskManualAltitude.
- Moving the scaling of full stick deflection to
radians per second into the class.
@MaEtUgR MaEtUgR self-assigned this Feb 24, 2023
@MaEtUgR MaEtUgR marked this pull request as ready for review February 24, 2023 17:02
@MaEtUgR MaEtUgR changed the title Descend nudging Allow nudging in failsafe Descend mode Feb 24, 2023
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this new feature on a slightly different base branch, and it worked as expected while not causing noticeable changes to other flight modes. And on the side improves code cleanliness. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants