Do not handle yaw stick multiple times in Altitude and Position mode #21781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When helping @marcinolokk with a new slower Position mode input feature I realized that there is quite some duplication in yaw handling over
FlightTaskManualAltitude
andFlightTaskManualAcceleration
.I had unified the handling in the
StickYaw
class in #21192 but apparently did not follow through and only use it once for all cases.Solution
StickYaw
class inFlightTaskManaulAcceleration
. It inherits the instance fromFlightTaskManualAltitude
and also calls the update by runningFlightTaskManualAltitude
's update already.FlightTaskManualAltitude
which was replaced by the unifiedStickYaw
class.Changelog Entry
The user should not notice a difference although this is a bug.
Test coverage
MPC_POS_MODE
settings and verified the yaw stick input still works. Now it must always be using theStickYaw
class inFlightTaskManualAltitude
only.