TECS: change default for FW_T_I_GAIN_THR from 0.3 to more appropriate 0.1 #21360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 0.1 Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
tstastny
approved these changes
Mar 23, 2023
|
I also came to the conclusion that in logs with the integrator gain set to 0.3 the integrator is causing a lot of throttle dynamics, especially when it's gusty. |
RomanBapst
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since with b1cbe04 the STE_rate_error gets properly filtered and not constantly reset to 0, the tuning has to be slightly adjusted. I found that the default for FW_T_I_GAIN_THR of 0.3 is now way to high on most vehicles. This PR is to basically revert to what was before the 3d3ff75 and the filtering bug had been introduced.