Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Drone ID arming check #21652

Merged
merged 5 commits into from
Jun 1, 2023
Merged

Conversation

katzfey
Copy link
Contributor

@katzfey katzfey commented May 29, 2023

Solved Problem

The Open Drone ID system (aka Remote ID) should be present and healthy before the system can arm. There was no check for this so it has been added. A convenience parameter has also been added to change it to a warning but still allow arming or to disable the check completely.

@katzfey katzfey requested review from dagar and bkueng May 29, 2023 22:41
@dirksavage88
Copy link
Contributor

Some of this has been duplicated in #21647

Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go from my side.
@dirksavage88 are you ok with getting this in now? Or what's your preferred approach?

@dirksavage88
Copy link
Contributor

I can update my PR to work with this one

@bkueng
Copy link
Member

bkueng commented Jun 1, 2023

Alright, merging this.

@bkueng bkueng merged commit d2011e9 into PX4:main Jun 1, 2023
81 of 83 checks passed
@hamishwillee
Copy link
Contributor

hamishwillee commented Jun 29, 2023

@bkueng Shouldn't we add to https://mavlink.io/en/messages/common.html#MAV_SYS_STATUS_SENSOR_EXTENDED and export this information?

The spec also indicates we should be listening to OPEN_DRONE_ID_ARM_STATUS and using that to set our health status too - but as far as I can tell our health check = connection check = 3 second heartbeat timeout.

I can see that we're reporting events, but they appear to be PX4-specific, and this is an standard feature.

Questions are to help me with docs.

@PX4 PX4 deleted a comment from Sidzeppelin95 Jun 29, 2023
@bkueng
Copy link
Member

bkueng commented Jul 3, 2023

I'm ok with adding it but I'm not sure if that would create a redundancy as I'm not in-depth familiar with how open drone id messaging is supposed to work.

@hamishwillee
Copy link
Contributor

Thanks @bkueng The spec actually states that the [OPEN_DRONE_ID_ARM_STATUS](https://mavlink.io/en/messages/common.html#OPEN_DRONE_ID_ARM_STATUS) must also be forwarded to the GCS ("must" seems a bit strong since you might not have one- I'm in discussion)

So I would expect PX4 to do that, and also to do whatever else we do when we fail a prearm check - an event I think.

No need to add to MAV_SYS_STATUS_SENSOR_EXTENDED then - though doing that would have made sense to me.

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/remote-id-coordination-july-11th/33191/1

antbre pushed a commit to BioMorphic-Intelligence-Lab/PX4-Autopilot that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants