-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Open Drone ID arming check #21652
Conversation
src/modules/commander/HealthAndArmingChecks/checks/openDroneIDCheck.cpp
Outdated
Show resolved
Hide resolved
Some of this has been duplicated in #21647 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go from my side.
@dirksavage88 are you ok with getting this in now? Or what's your preferred approach?
I can update my PR to work with this one |
Alright, merging this. |
@bkueng Shouldn't we add to https://mavlink.io/en/messages/common.html#MAV_SYS_STATUS_SENSOR_EXTENDED and export this information? The spec also indicates we should be listening to OPEN_DRONE_ID_ARM_STATUS and using that to set our health status too - but as far as I can tell our health check = connection check = 3 second heartbeat timeout. I can see that we're reporting events, but they appear to be PX4-specific, and this is an standard feature. Questions are to help me with docs. |
I'm ok with adding it but I'm not sure if that would create a redundancy as I'm not in-depth familiar with how open drone id messaging is supposed to work. |
Thanks @bkueng The spec actually states that the So I would expect PX4 to do that, and also to do whatever else we do when we fail a prearm check - an event I think. No need to add to MAV_SYS_STATUS_SENSOR_EXTENDED then - though doing that would have made sense to me. |
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/remote-id-coordination-july-11th/33191/1 |
Solved Problem
The Open Drone ID system (aka Remote ID) should be present and healthy before the system can arm. There was no check for this so it has been added. A convenience parameter has also been added to change it to a warning but still allow arming or to disable the check completely.