Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.14 Backport. Fix Rover Thrust Normalization #21722

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Release 1.14 Backport. Fix Rover Thrust Normalization #21722

merged 1 commit into from
Jul 11, 2023

Conversation

AlexKlimaj
Copy link
Member

@AlexKlimaj AlexKlimaj commented Jun 14, 2023 •
edited by junwoo091400

Backport of #21271 to 1.14 release

@AlexKlimaj AlexKlimaj mentioned this pull request Jun 14, 2023
Closed
@junwoo091400 junwoo091400 added Rover 🚙 Rovers and other UGV Release: backport 🔙 and removed Rover 🚙 Rovers and other UGV labels Jun 26, 2023
@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-maintainers-call-july-04-2023/32943/1

@mrpollo mrpollo requested review from dagar and removed request for Jaeyoung-Lim July 4, 2023 15:22
@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-community-q-a-july-05-2023/32963/1

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-maintainers-call-july-11-2023/33057/1

@junwoo091400
Copy link
Contributor

Note: We will have to change Gazebo airframe configuration, so that after this PR is merged the Gazebo Rover would work still.

MaEtUgR
MaEtUgR approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure Gazebo rover doesn't break. Since that was why this was changed.

@mrpollo mrpollo merged commit 89b238f into PX4:release/1.14 Jul 11, 2023
1 check passed
@MaEtUgR
Copy link
Member

MaEtUgR commented Jul 11, 2023

Simulation follow-up in the original pr: #21271 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaEtUgR MaEtUgR MaEtUgR approved these changes

@dagar dagar Awaiting requested review from dagar

Assignees
No one assigned
Labels
Release: backport 🔙
Projects
PX4 v1.15 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AlexKlimaj @DronecodeBot @junwoo091400 @MaEtUgR @mrpollo