Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.14 Backport. Fix Rover Thrust Normalization #21722

Merged
merged 1 commit into from
Jul 11, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/modules/rover_pos_control/RoverPositionControl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ RoverPositionControl::manual_control_setpoint_poll()
}

_att_sp.yaw_body = _manual_yaw_sp;
_att_sp.thrust_body[0] = (_manual_control_setpoint.throttle + 1.f) * .5f;
_att_sp.thrust_body[0] = _manual_control_setpoint.throttle;

Quatf q(Eulerf(_att_sp.roll_body, _att_sp.pitch_body, _att_sp.yaw_body));
q.copyTo(_att_sp.q_d);
Expand All @@ -152,7 +152,7 @@ RoverPositionControl::manual_control_setpoint_poll()
// Set heading from the manual roll input channel
_yaw_control = _manual_control_setpoint.roll; // Nominally yaw: _manual_control_setpoint.yaw;
// Set throttle from the manual throttle channel
_throttle_control = (_manual_control_setpoint.throttle + 1.f) * .5f;
_throttle_control = _manual_control_setpoint.throttle;
_reset_yaw_sp = true;
}

Expand Down
Loading