-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions: Use Debian 11 for linux targets and have the required cmake version #21749
Conversation
It's debian based: https://github.com/PX4/PX4-containers/blob/master/docker/Dockerfile_armhf#LL10C6-L10C19
It's the same cmake version like in the container we're using right now. Will not go to 3.16 which is required. |
|
I updated, tested and ended up with this: PX4/PX4-containers#332 Let me know if that's acceptable. Then I can push the updated container and use it in this pr. |
ok, I merged PX4/PX4-containers#332, tagged the containers 2023-06-26 and it got pushed 🎉 |
1dd55fe
to
e72a3c2
Compare
748b301
to
9612461
Compare
This solves the CI problem related to the required cmake version described here: #21737 (review) See PX4/PX4-containers#332 for the container changes.
5d8377d
to
aaf66af
Compare
until I figure out what a better solution would look like. See actions/runner#2033
aaf66af
to
3dad0ab
Compare
Solved Problem
See #21737 (review)
Solution
Update the container version to https://hub.docker.com/layers/px4io/px4-dev-armhf/2023-06-26/images/sha256-a40450559a433f98e93285d8757e775190ae7e3aa0a94590422e4b8a526d7728 which I did the changes for and locally tested here: PX4/PX4-containers#332
There's a newer cmake version inside. Let's run CI and it should be back working.
Changelog Entry