Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions: Use Debian 11 for linux targets and have the required cmake version #21749

Merged
merged 2 commits into from
Jun 27, 2023
Merged

GitHub Actions: Use Debian 11 for linux targets and have the required cmake version #21749

merged 2 commits into from
Jun 27, 2023

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Jun 21, 2023 •
edited

Solved Problem

See #21737 (review)

Solution

Update the container version to https://hub.docker.com/layers/px4io/px4-dev-armhf/2023-06-26/images/sha256-a40450559a433f98e93285d8757e775190ae7e3aa0a94590422e4b8a526d7728 which I did the changes for and locally tested here: PX4/PX4-containers#332
There's a newer cmake version inside. Let's run CI and it should be back working.

Changelog Entry

- Fix CI by updating to Debian 11 for linux targets and have the required cmake version

@MaEtUgR MaEtUgR self-assigned this Jun 21, 2023
@MaEtUgR
Copy link
Member Author

MaEtUgR commented Jun 21, 2023 •
edited

It's debian based: https://github.com/PX4/PX4-containers/blob/master/docker/Dockerfile_armhf#LL10C6-L10C19
I tested latest debian:buster's camke version:

root@6fc2c8855407:/# cmake --version
cmake version 3.13.4

It's the same cmake version like in the container we're using right now. Will not go to 3.16 which is required.
We need to update the container base.

@MaEtUgR
Copy link
Member Author

MaEtUgR commented Jun 21, 2023

debian:bookworm contains cmake version 3.25.1 I'm testing the builds locally first.

@MaEtUgR
Copy link
Member Author

MaEtUgR commented Jun 21, 2023

I can reproduce the issue locally with a freshly built docker image ⚙️
image
Trying to update now.

@MaEtUgR
Copy link
Member Author

MaEtUgR commented Jun 22, 2023 •
edited

I updated, tested and ended up with this: PX4/PX4-containers#332 Let me know if that's acceptable. Then I can push the updated container and use it in this pr.

@tstastny tstastny mentioned this pull request Jun 23, 2023
Merged
@junwoo091400 junwoo091400 added the Build System 🏗️ Build systems like CMakelist, Makefile, Arm compiler, etc label Jun 26, 2023
@MaEtUgR MaEtUgR mentioned this pull request Jun 26, 2023
Merged
@MaEtUgR
Copy link
Member Author

MaEtUgR commented Jun 26, 2023

ok, I merged PX4/PX4-containers#332, tagged the containers 2023-06-26 and it got pushed 🎉
https://hub.docker.com/layers/px4io/px4-dev-armhf/2023-06-26/images/sha256-a40450559a433f98e93285d8757e775190ae7e3aa0a94590422e4b8a526d7728?context=explore
Now lets update this pr and run it again ⚙️

@MaEtUgR MaEtUgR force-pushed the maetugr/ci-linux-build-cmake-version branch from 1dd55fe to e72a3c2 Compare June 26, 2023 17:54
@MaEtUgR MaEtUgR changed the title [TEST] GitHub Actions: bump linux targets container GitHub Actions: Use Debian 11 for linux targets and have the required cmake version Jun 26, 2023
@MaEtUgR MaEtUgR force-pushed the maetugr/ci-linux-build-cmake-version branch 2 times, most recently from 748b301 to 9612461 Compare June 27, 2023 10:50
@MaEtUgR
GitHub Actions: use Debian 11 to build linux targets
2320668 
This solves the CI problem related to the required cmake version
described here:
#21737 (review)

See PX4/PX4-containers#332
for the container changes.
@MaEtUgR MaEtUgR force-pushed the maetugr/ci-linux-build-cmake-version branch 2 times, most recently from 5d8377d to aaf66af Compare June 27, 2023 14:38
@MaEtUgR
Github Actions: add workaround for dubious ownership errors
3dad0ab 
until I figure out what a better solution
would look like.
See
actions/runner#2033
@MaEtUgR MaEtUgR force-pushed the maetugr/ci-linux-build-cmake-version branch from aaf66af to 3dad0ab Compare June 27, 2023 14:44
@MaEtUgR
Copy link
Member Author

MaEtUgR commented Jun 27, 2023

image
Finally 🎉
Another rabbit hole of "detected dubious ownership in repository" git feature in some combination of container and git version later. Let's step by step unify CI more.

@MaEtUgR MaEtUgR merged commit a6d2c2c into main Jun 27, 2023
81 of 84 checks passed
@MaEtUgR MaEtUgR deleted the maetugr/ci-linux-build-cmake-version branch June 27, 2023 15:17
@MaEtUgR MaEtUgR mentioned this pull request Jul 11, 2023
Merged
This was referenced Jul 18, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MaEtUgR MaEtUgR

Labels
Build System 🏗️ Build systems like CMakelist, Makefile, Arm compiler, etc CI (Continuous Integration) 🤖
Projects
PX4 v1.15 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaEtUgR @junwoo091400